* [PATCH] Input: Adding support for touchpad on Dell XT2 model
@ 2013-10-25 15:39 Yunkang Tang
2013-10-26 7:18 ` Niels de Vos
2013-10-31 7:56 ` Dmitry Torokhov
0 siblings, 2 replies; 4+ messages in thread
From: Yunkang Tang @ 2013-10-25 15:39 UTC (permalink / raw)
To: dmitry.torokhov, cernekee, dturvene
Cc: linux-input, ndevos, gaspard, jclift, yunkang.tang
Hi all,
This patch adding the support for touchpad on Dell XT2 model.
It's a dual device with device ID: 73, 00, 14, that comply with "ALPS_PROTO_V2".
Signed-off-by: Yunkang Tang <yunkang.tang@cn.alps.com>
---
drivers/input/mouse/alps.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index ca7a26f..24b3626 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -103,6 +103,7 @@ static const struct alps_model_info alps_model_data[] = {
/* Dell Latitude E5500, E6400, E6500, Precision M4400 */
{ { 0x62, 0x02, 0x14 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf,
ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
+ { { 0x73, 0x00, 0x14 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf, ALPS_DUALPOINT }, /* Dell XT2 */
{ { 0x73, 0x02, 0x50 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf, ALPS_FOUR_BUTTONS }, /* Dell Vostro 1400 */
{ { 0x52, 0x01, 0x14 }, 0x00, ALPS_PROTO_V2, 0xff, 0xff,
ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED }, /* Toshiba Tecra A11-11L */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Input: Adding support for touchpad on Dell XT2 model
2013-10-25 15:39 [PATCH] Input: Adding support for touchpad on Dell XT2 model Yunkang Tang
@ 2013-10-26 7:18 ` Niels de Vos
2013-10-31 7:56 ` Dmitry Torokhov
1 sibling, 0 replies; 4+ messages in thread
From: Niels de Vos @ 2013-10-26 7:18 UTC (permalink / raw)
To: Yunkang Tang
Cc: dmitry.torokhov, cernekee, dturvene, linux-input, gaspard, jclift,
yunkang.tang
On Fri, Oct 25, 2013 at 11:39:41PM +0800, Yunkang Tang wrote:
> Hi all,
>
> This patch adding the support for touchpad on Dell XT2 model.
> It's a dual device with device ID: 73, 00, 14, that comply with "ALPS_PROTO_V2".
>
>
> Signed-off-by: Yunkang Tang <yunkang.tang@cn.alps.com>
Tested-by: Gaspard Jankowiak <gaspard@oknaj.eu>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
(well, for as far a one-line review goes)
Thanks!
> ---
> drivers/input/mouse/alps.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index ca7a26f..24b3626 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -103,6 +103,7 @@ static const struct alps_model_info alps_model_data[] = {
> /* Dell Latitude E5500, E6400, E6500, Precision M4400 */
> { { 0x62, 0x02, 0x14 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf,
> ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
> + { { 0x73, 0x00, 0x14 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf, ALPS_DUALPOINT }, /* Dell XT2 */
> { { 0x73, 0x02, 0x50 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf, ALPS_FOUR_BUTTONS }, /* Dell Vostro 1400 */
> { { 0x52, 0x01, 0x14 }, 0x00, ALPS_PROTO_V2, 0xff, 0xff,
> ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED }, /* Toshiba Tecra A11-11L */
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: Adding support for touchpad on Dell XT2 model
2013-10-25 15:39 [PATCH] Input: Adding support for touchpad on Dell XT2 model Yunkang Tang
2013-10-26 7:18 ` Niels de Vos
@ 2013-10-31 7:56 ` Dmitry Torokhov
2013-11-06 15:24 ` Gaspard Jankowiak
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2013-10-31 7:56 UTC (permalink / raw)
To: Yunkang Tang
Cc: cernekee, dturvene, linux-input, ndevos, gaspard, jclift,
yunkang.tang
On Fri, Oct 25, 2013 at 11:39:41PM +0800, Yunkang Tang wrote:
> Hi all,
>
> This patch adding the support for touchpad on Dell XT2 model.
> It's a dual device with device ID: 73, 00, 14, that comply with "ALPS_PROTO_V2".
>
>
> Signed-off-by: Yunkang Tang <yunkang.tang@cn.alps.com>
Applied, thank you.
> ---
> drivers/input/mouse/alps.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index ca7a26f..24b3626 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -103,6 +103,7 @@ static const struct alps_model_info alps_model_data[] = {
> /* Dell Latitude E5500, E6400, E6500, Precision M4400 */
> { { 0x62, 0x02, 0x14 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf,
> ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED },
> + { { 0x73, 0x00, 0x14 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf, ALPS_DUALPOINT }, /* Dell XT2 */
> { { 0x73, 0x02, 0x50 }, 0x00, ALPS_PROTO_V2, 0xcf, 0xcf, ALPS_FOUR_BUTTONS }, /* Dell Vostro 1400 */
> { { 0x52, 0x01, 0x14 }, 0x00, ALPS_PROTO_V2, 0xff, 0xff,
> ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED }, /* Toshiba Tecra A11-11L */
> --
> 1.8.1.2
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Input: Adding support for touchpad on Dell XT2 model
2013-10-31 7:56 ` Dmitry Torokhov
@ 2013-11-06 15:24 ` Gaspard Jankowiak
0 siblings, 0 replies; 4+ messages in thread
From: Gaspard Jankowiak @ 2013-11-06 15:24 UTC (permalink / raw)
To: Dmitry Torokhov, Yunkang Tang
Cc: cernekee, dturvene, linux-input, ndevos, jclift, yunkang.tang
On 31/10/13 08:56, Dmitry Torokhov wrote:
>
> Applied, thank you.
>
Hi,
I don't know how to go about this, but it seems the patch is affecting
other input devices. The trackpoint goes haywire when used, making the
cursor jump all over the place and triggering random "right clicks" on
the Latitude XT2. I don't know if it affects other models too.
Sorry for not spotting this earlier.
Name : kernel
Version : 3.11.6
Release : 201.fc19
Architecture: x86_64
Install Date: Tue 05 Nov 2013 09:22:37 CET
Group : System Environment/Kernel
Size : 134433560
License : GPLv2 and Redistributable, no modification permitted
Signature : RSA/SHA256, Sat 02 Nov 2013 22:00:51 CET, Key ID
07477e65fb4b18e6
Source RPM : kernel-3.11.6-201.fc19.src.rpm
Build Date : Sat 02 Nov 2013 15:35:07 CET
Best,
Gaspard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-06 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-25 15:39 [PATCH] Input: Adding support for touchpad on Dell XT2 model Yunkang Tang
2013-10-26 7:18 ` Niels de Vos
2013-10-31 7:56 ` Dmitry Torokhov
2013-11-06 15:24 ` Gaspard Jankowiak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).