* [PATCH] Input: mma8450 - add missing i2c_set_clientdata() in mma8450_probe()
@ 2013-11-11 6:24 Wei Yongjun
2013-11-11 7:37 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-11-11 6:24 UTC (permalink / raw)
To: dmitry.torokhov, grant.likely, rob.herring, wfp5p, broonie,
javier, sebastien.royen
Cc: yongjun_wei, linux-input
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add missing i2c_set_clientdata() in mma8450_probe(), otherwise
calling i2c_get_clientdata() in mma8450_remove() returns NULL.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/input/misc/mma8450.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
index f330969..92c43a1 100644
--- a/drivers/input/misc/mma8450.c
+++ b/drivers/input/misc/mma8450.c
@@ -204,6 +204,8 @@ static int mma8450_probe(struct i2c_client *c,
goto err_free_mem;
}
+ i2c_set_clientdata(c, m);
+
return 0;
err_free_mem:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: mma8450 - add missing i2c_set_clientdata() in mma8450_probe()
2013-11-11 6:24 [PATCH] Input: mma8450 - add missing i2c_set_clientdata() in mma8450_probe() Wei Yongjun
@ 2013-11-11 7:37 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2013-11-11 7:37 UTC (permalink / raw)
To: Wei Yongjun
Cc: grant.likely, rob.herring, wfp5p, broonie, javier,
sebastien.royen, yongjun_wei, linux-input
On Mon, Nov 11, 2013 at 02:24:20PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add missing i2c_set_clientdata() in mma8450_probe(), otherwise
> calling i2c_get_clientdata() in mma8450_remove() returns NULL.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thank you.
> ---
> drivers/input/misc/mma8450.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
> index f330969..92c43a1 100644
> --- a/drivers/input/misc/mma8450.c
> +++ b/drivers/input/misc/mma8450.c
> @@ -204,6 +204,8 @@ static int mma8450_probe(struct i2c_client *c,
> goto err_free_mem;
> }
>
> + i2c_set_clientdata(c, m);
> +
> return 0;
>
> err_free_mem:
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-11 7:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 6:24 [PATCH] Input: mma8450 - add missing i2c_set_clientdata() in mma8450_probe() Wei Yongjun
2013-11-11 7:37 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).