From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Friedrich Schöller" <linux@schoeller.se>
Cc: Henrik Rydberg <rydberg@euromail.se>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Input: Added thumb detection in BCM5974 multitouch driver
Date: Wed, 20 Nov 2013 21:05:51 -0800 [thread overview]
Message-ID: <20131121050549.GC4702@core.coreip.homeip.net> (raw)
In-Reply-To: <1384988052-31898-3-git-send-email-linux@schoeller.se>
Hi Friedrich,
On Wed, Nov 20, 2013 at 11:54:12PM +0100, Friedrich Schöller wrote:
> Trackpads with integrated buttons are hard to use when the driver responds to
> movements of the thumb that is resting or clicking on the surface of the
> trackpad. This patch adds rudimentary support to filter out these touch events.
>
> The feature can be turned on via sysfs:
> /sys/class/input/input[0-9]+/thumb_ignore:
> Enables thumb detection
> Values: 0/1
> /sys/class/input/input[0-9]+/thumb_ratio_on:
> When the ratio of ABS_MT_TOUCH_MINOR / ABS_MT_TOUCH_MAJOR
> times 100 is smaller than this value the touch qualifies
> as a thumb.
> /sys/class/input/input[0-9]+/thumb_ratio_off:
> When the ratio of ABS_MT_TOUCH_MINOR / ABS_MT_TOUCH_MAJOR
> times 100 is bigger than this value the touch no longer
> qualifies as a thumb.
> /sys/class/input/input[0-9]+/thumb_y_on:
> When ABS_MT_POSITION_Y is bigger than this value the touch
> qualifies as a thumb.
> /sys/class/input/input[0-9]+/thumb_y_off:
> When ABS_MT_POSITION_Y is smaller than this value the touch
> no longer qualifies as a thumb.
I'd rather this been implemented in userspace (synaptics and/or evdev X
drivers).
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-21 5:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 22:54 [PATCH 1/3] Input: Fixed ABS_MT_TOUCH_MINOR scale factor in BCM5974 multitouch driver Friedrich Schöller
2013-11-20 22:54 ` [PATCH 2/3] Input: Fixed pressure and tool width calculation " Friedrich Schöller
2013-11-21 9:17 ` Henrik Rydberg
2013-11-20 22:54 ` [PATCH 3/3] Input: Added thumb detection " Friedrich Schöller
2013-11-21 5:05 ` Dmitry Torokhov [this message]
2013-11-21 9:20 ` Henrik Rydberg
2013-11-21 9:05 ` [PATCH 1/3] Input: Fixed ABS_MT_TOUCH_MINOR scale factor " Henrik Rydberg
2013-11-22 15:54 ` Friedrich Schöller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121050549.GC4702@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@schoeller.se \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).