From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: serio: remove unnecessary pci_set_drvdata()
Date: Mon, 25 Nov 2013 18:11:29 -0800 [thread overview]
Message-ID: <20131126021128.GA31517@core.coreip.homeip.net> (raw)
In-Reply-To: <001b01cee983$f894c510$e9be4f30$%han@samsung.com>
On Mon, Nov 25, 2013 at 11:13:46AM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied, thank you.
> ---
> drivers/input/serio/pcips2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
> index 76f8383..13062f6 100644
> --- a/drivers/input/serio/pcips2.c
> +++ b/drivers/input/serio/pcips2.c
> @@ -181,7 +181,6 @@ static void pcips2_remove(struct pci_dev *dev)
> struct pcips2_data *ps2if = pci_get_drvdata(dev);
>
> serio_unregister_port(ps2if->io);
> - pci_set_drvdata(dev, NULL);
> kfree(ps2if);
> pci_release_regions(dev);
> pci_disable_device(dev);
> --
> 1.7.10.4
>
>
--
Dmitry
prev parent reply other threads:[~2013-11-26 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 2:13 [PATCH] Input: serio: remove unnecessary pci_set_drvdata() Jingoo Han
2013-11-26 2:11 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126021128.GA31517@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).