From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro
Date: Wed, 27 Nov 2013 23:35:50 -0800 [thread overview]
Message-ID: <20131128073550.GA25692@core.coreip.homeip.net> (raw)
In-Reply-To: <005001ceebf2$da2da300$8e88e900$%han@samsung.com>
On Thu, Nov 28, 2013 at 01:32:31PM +0900, Jingoo Han wrote:
> On Thursday, November 28, 2013 12:57 PM, Dmitry Torokhov wrote:
> > On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote:
> > > This macro is used to create a struct pci_device_id array.
> >
> > Applied all 3, thank you.
>
> Please, drop these patches.
> According to the Greg Kroah-Hartman,
>
> "Yeah, and it's a horrid macro that deserves to be removed, please don't
> use it in more places.
>
> Actually, if you could just remove it, that would be best, sorry, I'm
> not going to take these patches."
>
> So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead.
> Sorry for annoying. :-)
No worries, I dropped them.
Thanks.
--
Dmitry
prev parent reply other threads:[~2013-11-28 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 2:19 [PATCH 1/3] Input: emu10k1 - use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-11-28 2:20 ` [PATCH 2/3] Input: fm801-gp " Jingoo Han
2013-11-28 2:21 ` [PATCH 3/3] Input: pcips2 " Jingoo Han
2013-11-28 3:56 ` Dmitry Torokhov
2013-11-28 4:32 ` Jingoo Han
2013-11-28 7:35 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128073550.GA25692@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).