* [PATCH 1/3] Input: emu10k1 - use DEFINE_PCI_DEVICE_TABLE macro
@ 2013-11-28 2:19 Jingoo Han
2013-11-28 2:20 ` [PATCH 2/3] Input: fm801-gp " Jingoo Han
2013-11-28 2:21 ` [PATCH 3/3] Input: pcips2 " Jingoo Han
0 siblings, 2 replies; 6+ messages in thread
From: Jingoo Han @ 2013-11-28 2:19 UTC (permalink / raw)
To: 'Dmitry Torokhov'
Cc: 'Dmitry Torokhov', linux-input, 'Jingoo Han'
This macro is used to create a struct pci_device_id array.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/input/gameport/emu10k1-gp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/gameport/emu10k1-gp.c b/drivers/input/gameport/emu10k1-gp.c
index fa7a95c..72a7213 100644
--- a/drivers/input/gameport/emu10k1-gp.c
+++ b/drivers/input/gameport/emu10k1-gp.c
@@ -46,7 +46,7 @@ struct emu {
int size;
};
-static const struct pci_device_id emu_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(emu_tbl) = {
{ 0x1102, 0x7002, PCI_ANY_ID, PCI_ANY_ID }, /* SB Live gameport */
{ 0x1102, 0x7003, PCI_ANY_ID, PCI_ANY_ID }, /* Audigy gameport */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] Input: fm801-gp - use DEFINE_PCI_DEVICE_TABLE macro
2013-11-28 2:19 [PATCH 1/3] Input: emu10k1 - use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
@ 2013-11-28 2:20 ` Jingoo Han
2013-11-28 2:21 ` [PATCH 3/3] Input: pcips2 " Jingoo Han
1 sibling, 0 replies; 6+ messages in thread
From: Jingoo Han @ 2013-11-28 2:20 UTC (permalink / raw)
To: 'Dmitry Torokhov'
Cc: 'Dmitry Torokhov', linux-input, 'Jingoo Han'
This macro is used to create a struct pci_device_id array.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/input/gameport/fm801-gp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/gameport/fm801-gp.c b/drivers/input/gameport/fm801-gp.c
index ae912d3..5ace35bf 100644
--- a/drivers/input/gameport/fm801-gp.c
+++ b/drivers/input/gameport/fm801-gp.c
@@ -140,7 +140,7 @@ static void fm801_gp_remove(struct pci_dev *pci)
pci_disable_device(pci);
}
-static const struct pci_device_id fm801_gp_id_table[] = {
+static DEFINE_PCI_DEVICE_TABLE(fm801_gp_id_table) = {
{ PCI_VENDOR_ID_FORTEMEDIA, PCI_DEVICE_ID_FM801_GP, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
{ 0 }
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro
2013-11-28 2:19 [PATCH 1/3] Input: emu10k1 - use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-11-28 2:20 ` [PATCH 2/3] Input: fm801-gp " Jingoo Han
@ 2013-11-28 2:21 ` Jingoo Han
2013-11-28 3:56 ` Dmitry Torokhov
1 sibling, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2013-11-28 2:21 UTC (permalink / raw)
To: 'Dmitry Torokhov'
Cc: 'Dmitry Torokhov', linux-input, 'Jingoo Han'
This macro is used to create a struct pci_device_id array.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/input/serio/pcips2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
index 13062f6..2fff5d4 100644
--- a/drivers/input/serio/pcips2.c
+++ b/drivers/input/serio/pcips2.c
@@ -186,7 +186,7 @@ static void pcips2_remove(struct pci_dev *dev)
pci_disable_device(dev);
}
-static const struct pci_device_id pcips2_ids[] = {
+static DEFINE_PCI_DEVICE_TABLE(pcips2_ids) = {
{
.vendor = 0x14f2, /* MOBILITY */
.device = 0x0123, /* Keyboard */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro
2013-11-28 2:21 ` [PATCH 3/3] Input: pcips2 " Jingoo Han
@ 2013-11-28 3:56 ` Dmitry Torokhov
2013-11-28 4:32 ` Jingoo Han
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Torokhov @ 2013-11-28 3:56 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-input
On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote:
> This macro is used to create a struct pci_device_id array.
Applied all 3, thank you.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/input/serio/pcips2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
> index 13062f6..2fff5d4 100644
> --- a/drivers/input/serio/pcips2.c
> +++ b/drivers/input/serio/pcips2.c
> @@ -186,7 +186,7 @@ static void pcips2_remove(struct pci_dev *dev)
> pci_disable_device(dev);
> }
>
> -static const struct pci_device_id pcips2_ids[] = {
> +static DEFINE_PCI_DEVICE_TABLE(pcips2_ids) = {
> {
> .vendor = 0x14f2, /* MOBILITY */
> .device = 0x0123, /* Keyboard */
> --
> 1.7.10.4
>
>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro
2013-11-28 3:56 ` Dmitry Torokhov
@ 2013-11-28 4:32 ` Jingoo Han
2013-11-28 7:35 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: Jingoo Han @ 2013-11-28 4:32 UTC (permalink / raw)
To: 'Dmitry Torokhov'; +Cc: linux-input, 'Jingoo Han'
On Thursday, November 28, 2013 12:57 PM, Dmitry Torokhov wrote:
> On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote:
> > This macro is used to create a struct pci_device_id array.
>
> Applied all 3, thank you.
Please, drop these patches.
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't
use it in more places.
Actually, if you could just remove it, that would be best, sorry, I'm
not going to take these patches."
So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead.
Sorry for annoying. :-)
Best regards,
Jingoo Han
>
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/input/serio/pcips2.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/serio/pcips2.c b/drivers/input/serio/pcips2.c
> > index 13062f6..2fff5d4 100644
> > --- a/drivers/input/serio/pcips2.c
> > +++ b/drivers/input/serio/pcips2.c
> > @@ -186,7 +186,7 @@ static void pcips2_remove(struct pci_dev *dev)
> > pci_disable_device(dev);
> > }
> >
> > -static const struct pci_device_id pcips2_ids[] = {
> > +static DEFINE_PCI_DEVICE_TABLE(pcips2_ids) = {
> > {
> > .vendor = 0x14f2, /* MOBILITY */
> > .device = 0x0123, /* Keyboard */
> > --
> > 1.7.10.4
> >
> >
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] Input: pcips2 - use DEFINE_PCI_DEVICE_TABLE macro
2013-11-28 4:32 ` Jingoo Han
@ 2013-11-28 7:35 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2013-11-28 7:35 UTC (permalink / raw)
To: Jingoo Han; +Cc: linux-input
On Thu, Nov 28, 2013 at 01:32:31PM +0900, Jingoo Han wrote:
> On Thursday, November 28, 2013 12:57 PM, Dmitry Torokhov wrote:
> > On Thu, Nov 28, 2013 at 11:21:12AM +0900, Jingoo Han wrote:
> > > This macro is used to create a struct pci_device_id array.
> >
> > Applied all 3, thank you.
>
> Please, drop these patches.
> According to the Greg Kroah-Hartman,
>
> "Yeah, and it's a horrid macro that deserves to be removed, please don't
> use it in more places.
>
> Actually, if you could just remove it, that would be best, sorry, I'm
> not going to take these patches."
>
> So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead.
> Sorry for annoying. :-)
No worries, I dropped them.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-28 7:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-28 2:19 [PATCH 1/3] Input: emu10k1 - use DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-11-28 2:20 ` [PATCH 2/3] Input: fm801-gp " Jingoo Han
2013-11-28 2:21 ` [PATCH 3/3] Input: pcips2 " Jingoo Han
2013-11-28 3:56 ` Dmitry Torokhov
2013-11-28 4:32 ` Jingoo Han
2013-11-28 7:35 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).