From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yunkang Tang <tommywill2011@gmail.com>
Cc: cernekee@gmail.com, dturvene@dahetral.com,
linux-input@vger.kernel.org, ndevos@redhat.com,
yunkang.tang@cn.alps.com
Subject: Re: [PATCH v4 1/1] Input: Improve the performance of alps v5-protocol's touchpad
Date: Sun, 1 Dec 2013 22:41:21 -0800 [thread overview]
Message-ID: <20131202064121.GD21404@core.coreip.homeip.net> (raw)
In-Reply-To: <1382355711-3211-1-git-send-email-yunkang.tang@cn.alps.com>
Hi Yunkang,
On Mon, Oct 21, 2013 at 07:41:50PM +0800, Yunkang Tang wrote:
> +static void alps_process_packet_v5(struct psmouse *psmouse)
> +{
> + unsigned char *packet = psmouse->packet;
> +
> + /* Ignore stick point data */
> + if (packet[0] == 0xD8)
> + return;
Why are we ignoring trackstick data? If there Dolphin models with
tracksticks that would basically "break" the device for users compared
withe the emulated Explorer PS/2 mode.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-12-02 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 11:41 [PATCH v4 1/1] Input: Improve the performance of alps v5-protocol's touchpad Yunkang Tang
2013-10-23 11:29 ` Justin Clift
2013-10-23 13:56 ` Tommy Will
2013-11-01 6:00 ` Tommy Will
2013-12-02 6:41 ` Dmitry Torokhov [this message]
2013-12-02 7:37 ` Tommy Will
2013-12-02 14:16 ` Tommy Will
2013-12-20 9:35 ` Tommy Will
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202064121.GD21404@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=cernekee@gmail.com \
--cc=dturvene@dahetral.com \
--cc=linux-input@vger.kernel.org \
--cc=ndevos@redhat.com \
--cc=tommywill2011@gmail.com \
--cc=yunkang.tang@cn.alps.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).