From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
leosilva@linux.vnet.ibm.com, ashley@ashleylai.com,
peterhuewe@gmx.de, mail@srajiv.net, tpmdd@selhorst.net,
tpmdd@sirrix.com, bhelgaas@google.com, plagnioj@jcrosoft.com,
tomi.valkeinen@ti.com, tpmdd-devel@lists.sourceforge.net,
linux-input@vger.kernel.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up.
Date: Wed, 4 Dec 2013 11:48:03 -0500 [thread overview]
Message-ID: <20131204164802.GG391@pegasus.dumpdata.com> (raw)
In-Reply-To: <20131204164218.GA8838@core.coreip.homeip.net>
> > which is hardly nice. This patch fixes this by having each
> > PV driver check for:
> > - if running in PV, then it is fine to execute (as that is their
> > native environment).
> > - if running in HVM, check if user wanted 'xen_emul_unplug=never',
> > in which case bail out and don't load PV drivers.
> > - if running in HVM, and if PCI device 5853:0001 (xen_platform_pci)
> > does not exist, then bail out and not load PV drivers.
> >
> > P.S.
> > Ian Campbell suggested getting rid of 'xen_platform_pci_unplug'
> > but unfortunatly the xen-blkfront driver is using it, so we
> > cannot do it.
> >
> > Reported-by: Sander Eikelenboom <linux@eikelenboom.it
> > Reported-by: Anthony PERARD <anthony.perard@citrix.com>
> > Reported-by: Fabio Fantoni <fabio.fantoni@m2r.biz>
>
> For input:
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thank you. I need to do some extra changes to the other subsystems but
for the fb/kbd itshould be still throught the same function as this
patch has exposed. I will repost it and include your Ack if you are OK
with that?
>
> ...
>
> > +#if defined(CONFIG_XEN_PVHVM)
> > +extern bool xen_has_pv_devices(void);
> > +#else
> > +static inline bool xen_has_pv_devices(void)
> > +{
> > +#if defined(CONFIG_XEN)
> > + return true;
> > +#else
> > + return false;
> > +#endif
>
> return IS_ENABLED(CONFIG_XEN);
>
> ?
Oh, awesome! Thanks!
next prev parent reply other threads:[~2013-12-04 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 21:14 [PATCH] xen/pvhvm: If xen_platform_pci=0 is set don't blow up Konrad Rzeszutek Wilk
2013-12-04 0:03 ` [Xen-devel] " Matthew Daley
2013-12-04 9:37 ` Ian Campbell
2013-12-04 10:51 ` Stefano Stabellini
2013-12-04 10:59 ` Ian Campbell
2013-12-04 11:05 ` Stefano Stabellini
2013-12-04 11:08 ` Ian Campbell
2013-12-04 11:18 ` Stefano Stabellini
2013-12-04 11:23 ` Ian Campbell
2013-12-04 10:48 ` Stefano Stabellini
2013-12-04 13:00 ` David Vrabel
2013-12-04 13:06 ` Ian Campbell
2013-12-04 16:42 ` Dmitry Torokhov
2013-12-04 16:48 ` Konrad Rzeszutek Wilk [this message]
2013-12-04 17:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204164802.GG391@pegasus.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=ashley@ashleylai.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=netdev@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=plagnioj@jcrosoft.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tomi.valkeinen@ti.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=tpmdd@sirrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).