linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/input/mouse: add support for newer elantech touchpads (released ca. August 2013);
@ 2013-12-03 17:42 Matt Walker
  2013-12-04 17:18 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Walker @ 2013-12-03 17:42 UTC (permalink / raw)
  To: Hauke Mehrtens
  Cc: backports-u79uwXL29TY76Z2rM5mHXA,
	linux-input-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]

From: Matt Walker <matt.g.d.walker-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Added detection for newer Elantech touchpads, so that kernel doesn't
fall-back to default PS/2 driver. Supports touchpads released after
~August 2013.  Fixes bug:
https://lists.launchpad.net/kernel-packages/msg18481.html

Tested-by: Matt Walker <matt.g.d.walker-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> on an Acer Aspire S7-392-6302

----

Thanks to Hauke for the reference on how to submit a patch properly.
Please let me know if additional modifications are required.

Diff Output:

--- linux-3.13-rc1/drivers/input/mouse/elantech.c.orig    2013-12-03
12:14:52.829173656 -0500
+++ linux-3.13-rc1/drivers/input/mouse/elantech.c    2013-12-03
12:15:11.833173880 -0500
@@ -1313,6 +1313,7 @@ static int elantech_set_properties(struc
             break;
         case 6:
         case 7:
+        case 8:
             etd->hw_version = 4;
             break;
         default:


On Fri, Nov 29, 2013 at 4:26 PM, Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> wrote:
> On 11/29/2013 01:00 AM, Matt Walker wrote:
>> Hello,
>>
>> Attached is a patch for drivers/input/mouse/elantech.c.  It allows
>> recent Elantech touchpads to be detected.  I have tested it on the
>> touchpad that comes with the Acer Aspire S7-392 (released ~August
>> 2013)
>>
>> I figure it could be backported with little effort and no danger,
>> since all it does it add one to the number of values that were
>> previously recognized as valid "firmware version numbers".
>>
>> Begin Patch:
>> 1315a1316
>>>         case 8:
>> End Patch
>>
>> Best,
>> Matt
>>
> This is not a patch, I do not know what you want to do.
>
> This is the documentation for hacking on backprts:
> https://backports.wiki.kernel.org/index.php/Documentation/backports/hacking
>
> This is the guideline for patch submission to the linux kernel which
> mostly also applies for backports:
> https://www.kernel.org/doc/Documentation/SubmittingPatches
>
> Hauke

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 332 bytes --]

--- linux-3.13-rc1/drivers/input/mouse/elantech.c.orig	2013-12-03 12:14:52.829173656 -0500
+++ linux-3.13-rc1/drivers/input/mouse/elantech.c	2013-12-03 12:15:11.833173880 -0500
@@ -1313,6 +1313,7 @@ static int elantech_set_properties(struc
 			break;
 		case 6:
 		case 7:
+		case 8:
 			etd->hw_version = 4;
 			break;
 		default:

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/input/mouse: add support for newer elantech touchpads (released ca. August 2013);
  2013-12-03 17:42 [PATCH] drivers/input/mouse: add support for newer elantech touchpads (released ca. August 2013); Matt Walker
@ 2013-12-04 17:18 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2013-12-04 17:18 UTC (permalink / raw)
  To: Matt Walker; +Cc: Hauke Mehrtens, backports, linux-input, linux-kernel

On Tue, Dec 03, 2013 at 12:42:34PM -0500, Matt Walker wrote:
> From: Matt Walker <matt.g.d.walker@gmail.com>
> 
> Added detection for newer Elantech touchpads, so that kernel doesn't
> fall-back to default PS/2 driver. Supports touchpads released after
> ~August 2013.  Fixes bug:
> https://lists.launchpad.net/kernel-packages/msg18481.html
> 
> Tested-by: Matt Walker <matt.g.d.walker@gmail.com> on an Acer Aspire S7-392-6302

That should be "Signed-off-by: ...". Could you please add your sign off
and resend so I can apply?

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-04 17:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 17:42 [PATCH] drivers/input/mouse: add support for newer elantech touchpads (released ca. August 2013); Matt Walker
2013-12-04 17:18 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).