From: Sebastian Reichel <sre@debian.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Dmitry Torokhov <dtor@mail.ru>,
linux-input@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation: dt: Document TSC2005 DT binding
Date: Mon, 9 Dec 2013 19:24:10 +0100 [thread overview]
Message-ID: <20131209182409.GA7626@earth.universe> (raw)
In-Reply-To: <20131209174638.GC12527@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
On Mon, Dec 09, 2013 at 09:46:38AM -0800, Tony Lindgren wrote:
> > +Optional properties:
> > + - ti,fuzz-x : integer, X noise value of the touchscreen
> > + (defaults to 4)
> > + - ti,fuzz-y : integer, Y noise value of the touchscreen
> > + (defaults to 8)
> > + - ti,fuzz-pressure : integer, pressure noise value of the touchscreen
> > + (defaults to 2)
> > + - ti,max-x : integer, maximum reported x value
> > + (defaults to 4096)
> > + - ti,max-y : integer, maximum reported y value
> > + (defaults to 4096)
> > + - ti,max-pressure : integer, maximum reported pressure
> > + (defaults to 4096)
> > + - ti,x-plate-resistance : integer, resistance of the touchscreen's X plates
> > + in ohm (defaults to 280)
> > + - ti,esd-recovery-timeout-ms : integer, if the touchscreen does not respond after
> > + the configured time (in milli seconds), the driver
> > + will reset it. This is disabled by default.
>
> Instead of adding these optional ti,* properties you can set them in the
> driver directly in the of_match table based on the compatible flag. Then
> you can pass compatible flag like ti,tsc2005-nokia-n900, or the name of
> the LCD panel. Most likely these depend on the LCD panel selected.
I could certainly do this, but it would move the board specific data
from the boardcode into the driver. That looks contra-productive to
me. Is there a good reason to do it this way?
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-09 18:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 23:09 [PATCH 0/2] tsc2005 DT binding Sebastian Reichel
2013-12-05 23:09 ` [PATCH 1/2] Input: tsc2005: add DT support Sebastian Reichel
2013-12-05 23:09 ` [PATCH 2/2] Documentation: dt: Document TSC2005 DT binding Sebastian Reichel
2013-12-09 17:46 ` Tony Lindgren
2013-12-09 18:24 ` Sebastian Reichel [this message]
2013-12-10 0:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131209182409.GA7626@earth.universe \
--to=sre@debian.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@mail.ru \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).