From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/7] Input: pmic8xxx-pwrkey - Pass input device directly to interrupt Date: Sun, 15 Dec 2013 03:21:04 -0800 Message-ID: <20131215112103.GA14818@core.coreip.homeip.net> References: <1386718996-3733-1-git-send-email-sboyd@codeaurora.org> <1386718996-3733-2-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f52.google.com ([209.85.160.52]:33565 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753903Ab3LOLVK (ORCPT ); Sun, 15 Dec 2013 06:21:10 -0500 Content-Disposition: inline In-Reply-To: <1386718996-3733-2-git-send-email-sboyd@codeaurora.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org Hi Stephen, On Tue, Dec 10, 2013 at 03:43:10PM -0800, Stephen Boyd wrote: > Instead of passing the pointer to the container structure just > pass the input device here. This saves a dereference in the fast > path. > > Signed-off-by: Stephen Boyd > --- > drivers/input/misc/pmic8xxx-pwrkey.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c > index ce3c426..233b216 100644 > --- a/drivers/input/misc/pmic8xxx-pwrkey.c > +++ b/drivers/input/misc/pmic8xxx-pwrkey.c > @@ -32,26 +32,21 @@ > * @key_press_irq: key press irq number > */ > struct pmic8xxx_pwrkey { > - struct input_dev *pwr; This causes compile errors as you need pwrkey->pwr in remove() to unregister input device. I'll fix it up. > int key_press_irq; > }; > > -static irqreturn_t pwrkey_press_irq(int irq, void *_pwrkey) > +static irqreturn_t pwrkey_press_irq(int irq, void *pwr) > { > - struct pmic8xxx_pwrkey *pwrkey = _pwrkey; > - > - input_report_key(pwrkey->pwr, KEY_POWER, 1); > - input_sync(pwrkey->pwr); > + input_report_key(pwr, KEY_POWER, 1); > + input_sync(pwr); > > return IRQ_HANDLED; > } > > -static irqreturn_t pwrkey_release_irq(int irq, void *_pwrkey) > +static irqreturn_t pwrkey_release_irq(int irq, void *pwr) > { > - struct pmic8xxx_pwrkey *pwrkey = _pwrkey; > - > - input_report_key(pwrkey->pwr, KEY_POWER, 0); > - input_sync(pwrkey->pwr); > + input_report_key(pwr, KEY_POWER, 0); > + input_sync(pwr); > > return IRQ_HANDLED; > } > @@ -147,12 +142,11 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev) > } > > pwrkey->key_press_irq = key_press_irq; > - pwrkey->pwr = pwr; > > platform_set_drvdata(pdev, pwrkey); > > err = devm_request_irq(&pdev->dev, key_press_irq, pwrkey_press_irq, > - IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_press", pwrkey); > + IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_press", pwr); > if (err < 0) { > dev_dbg(&pdev->dev, "Can't get %d IRQ for pwrkey: %d\n", > key_press_irq, err); > @@ -160,7 +154,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev) > } > > err = devm_request_irq(&pdev->dev, key_release_irq, pwrkey_release_irq, > - IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_release", pwrkey); > + IRQF_TRIGGER_RISING, "pmic8xxx_pwrkey_release", pwr); > if (err < 0) { > dev_dbg(&pdev->dev, "Can't get %d IRQ for pwrkey: %d\n", > key_release_irq, err); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > hosted by The Linux Foundation > -- Dmitry