From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-input@vger.kernel.org, "Hauke Mehrtens" <hauke@hauke-m.de>
Subject: Re: [PATCH V2] Input: define KEY_WWAN for Wireless WAN
Date: Sun, 15 Dec 2013 21:02:03 -0800 [thread overview]
Message-ID: <20131216050157.GB4322@core.coreip.homeip.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1312102036250.1413@pobox.suse.cz>
On Tue, Dec 10, 2013 at 08:36:41PM +0100, Jiri Kosina wrote:
> On Tue, 10 Dec 2013, Rafał Miłecki wrote:
>
> > Some devices with support for mobile networks may have buttons for
> > enabling/disabling such connection. An example can be Linksys router
> > 54G3G.
> > We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB so it makes sense
> > to add KEY_WWAN as well.
> > As we already have KEY_WIMAX, use it's value for KEY_WWAN and make it an
> > alias.
> >
> > Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> > ---
> > V2: Re-use 246 value for WWAN and make WIMAX an aliast to WWAN
> > ---
> > include/uapi/linux/input.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> > index a372627..7c69941 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -464,7 +464,8 @@ struct input_keymap_entry {
> > #define KEY_BRIGHTNESS_ZERO 244 /* brightness off, use ambient */
> > #define KEY_DISPLAY_OFF 245 /* display device to off state */
> >
> > -#define KEY_WIMAX 246
> > +#define KEY_WWAN 246 /* Wireless WAN (LTE, UMTS, GSM, etc.) */
> > +#define KEY_WIMAX KEY_WWAN
> > #define KEY_RFKILL 247 /* Key that controls all radios */
> >
> > #define KEY_MICMUTE 248 /* Mute / unmute the microphone */
>
> Adding Dmitry to CC
Applied, thank you.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-12-16 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-28 18:42 [PATCH] Input: define KEY_WWAN for Wireless WAN Rafał Miłecki
2013-12-04 17:10 ` Dmitry Torokhov
2013-12-04 18:00 ` Rafał Miłecki
2013-12-10 10:29 ` [PATCH V2] " Rafał Miłecki
2013-12-10 19:36 ` Jiri Kosina
2013-12-16 5:02 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216050157.GB4322@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).