From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
lars@metafoo.de, sachin.kamat@linaro.org,
yongjun_wei@trendmicro.com.cn, linux-input@vger.kernel.org
Subject: Re: [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq()
Date: Tue, 17 Dec 2013 08:48:28 -0800 [thread overview]
Message-ID: <20131217164828.GA17790@core.coreip.homeip.net> (raw)
In-Reply-To: <20131217012358.GA31766@codeaurora.org>
On Mon, Dec 16, 2013 at 05:23:58PM -0800, Stephen Boyd wrote:
> On 12/17, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > free_irq() in the error handling case is missing when change
> > pass input device directly to interrupt.
> >
> > Fixes: b27f8fee4965('Input: pmic8xxx-pwrkey - pass input device directly to interrupt')
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> This driver was supposed to be converted to devm before
> that patch. I forgot to send it and then Dmitry seems to have
> fixed up the patch to make it apply. We should just use the devm
> conversion patch to avoid needing to apply this one.
I am still going to apply it, but if you could take a look at my devm
conversion patch for the driver that would be great.
Thanks.
--
Dmitry
prev parent reply other threads:[~2013-12-17 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 1:16 [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq() Wei Yongjun
2013-12-17 1:23 ` Stephen Boyd
2013-12-17 16:48 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131217164828.GA17790@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).