* [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq()
@ 2013-12-17 1:16 Wei Yongjun
2013-12-17 1:23 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2013-12-17 1:16 UTC (permalink / raw)
To: dmitry.torokhov, sboyd, lars, sachin.kamat; +Cc: yongjun_wei, linux-input
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
free_irq() in the error handling case is missing when change
pass input device directly to interrupt.
Fixes: b27f8fee4965('Input: pmic8xxx-pwrkey - pass input device directly to interrupt')
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/input/misc/pmic8xxx-pwrkey.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/misc/pmic8xxx-pwrkey.c b/drivers/input/misc/pmic8xxx-pwrkey.c
index ef93840..3914e5b 100644
--- a/drivers/input/misc/pmic8xxx-pwrkey.c
+++ b/drivers/input/misc/pmic8xxx-pwrkey.c
@@ -182,7 +182,7 @@ static int pmic8xxx_pwrkey_probe(struct platform_device *pdev)
return 0;
free_press_irq:
- free_irq(key_press_irq, pwrkey);
+ free_irq(key_press_irq, pwr);
unreg_input_dev:
input_unregister_device(pwr);
pwr = NULL;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq()
2013-12-17 1:16 [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq() Wei Yongjun
@ 2013-12-17 1:23 ` Stephen Boyd
2013-12-17 16:48 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2013-12-17 1:23 UTC (permalink / raw)
To: Wei Yongjun; +Cc: dmitry.torokhov, lars, sachin.kamat, yongjun_wei, linux-input
On 12/17, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> free_irq() in the error handling case is missing when change
> pass input device directly to interrupt.
>
> Fixes: b27f8fee4965('Input: pmic8xxx-pwrkey - pass input device directly to interrupt')
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
This driver was supposed to be converted to devm before
that patch. I forgot to send it and then Dmitry seems to have
fixed up the patch to make it apply. We should just use the devm
conversion patch to avoid needing to apply this one.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq()
2013-12-17 1:23 ` Stephen Boyd
@ 2013-12-17 16:48 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2013-12-17 16:48 UTC (permalink / raw)
To: Stephen Boyd; +Cc: Wei Yongjun, lars, sachin.kamat, yongjun_wei, linux-input
On Mon, Dec 16, 2013 at 05:23:58PM -0800, Stephen Boyd wrote:
> On 12/17, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > free_irq() in the error handling case is missing when change
> > pass input device directly to interrupt.
> >
> > Fixes: b27f8fee4965('Input: pmic8xxx-pwrkey - pass input device directly to interrupt')
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> This driver was supposed to be converted to devm before
> that patch. I forgot to send it and then Dmitry seems to have
> fixed up the patch to make it apply. We should just use the devm
> conversion patch to avoid needing to apply this one.
I am still going to apply it, but if you could take a look at my devm
conversion patch for the driver that would be great.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-17 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 1:16 [PATCH -next] Input: pmic8xxx-pwrkey - fix to pass correct device identity to free_irq() Wei Yongjun
2013-12-17 1:23 ` Stephen Boyd
2013-12-17 16:48 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).