From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yunkang Tang <tommywill2011@gmail.com>
Cc: cernekee@gmail.com, dturvene@dahetral.com,
linux-input@vger.kernel.org, ndevos@redhat.com,
jclift@redhat.com, yunkang.tang@cn.alps.com
Subject: Re: [PATCH v5] Input: Improve the performance of alps v5-protocol's touchpad
Date: Thu, 26 Dec 2013 16:00:12 -0800 [thread overview]
Message-ID: <20131227000012.GA8147@core.coreip.homeip.net> (raw)
In-Reply-To: <1387876717-3878-1-git-send-email-yunkang.tang@cn.alps.com>
On Tue, Dec 24, 2013 at 05:18:37PM +0800, Yunkang Tang wrote:
> Hi all,
>
> Here is the 5th patch of supporting ALPS v5 protocol's device.
>
> Change since v4:
> - Use temporary variables to store the result of fls() and ffs(). (Suggestion by Kevin)
> - Use PSMOUSE_* macro instead of raw hex directly. (Suggestion by Kevin)
> - Change V5 device's mask0 from 0xc8 to 0xd8 to protect the abnormal case. (Discuss with Dmitry)
>
> Self test with v5 device:
> - Checked on both 32-bit & 64-bit environment.
> - Cursor moves correctly.
> - 1Finger Tap/Drag works well.
> - 2Finger Tap works well.
> - 2Finger Scroll works well.
> - L/R Buttons do function
>
> Signed-off-by: Yunkang Tang <yunkang.tang@cn.alps.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2013-12-27 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 9:18 [PATCH v5] Input: Improve the performance of alps v5-protocol's touchpad Yunkang Tang
2013-12-27 0:00 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131227000012.GA8147@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=cernekee@gmail.com \
--cc=dturvene@dahetral.com \
--cc=jclift@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=ndevos@redhat.com \
--cc=tommywill2011@gmail.com \
--cc=yunkang.tang@cn.alps.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).