From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 2/5] input: sun4i-ts: Add support for temperature sensor Date: Fri, 27 Dec 2013 17:13:04 -0800 Message-ID: <20131228011304.GB14188@core.coreip.homeip.net> References: <1388156399-29677-1-git-send-email-hdegoede@redhat.com> <1388156399-29677-3-git-send-email-hdegoede@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1388156399-29677-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline To: Hans de Goede Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LM Sensors , Maxime Ripard , Corentin LABBE , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-input@vger.kernel.org On Fri, Dec 27, 2013 at 03:59:56PM +0100, Hans de Goede wrote: > > +Optional properties: > + - ts-attached: boolean set this to tell the driver that an actual touchscreen > + is attached and that it should register an input device, > + without this it only registers the builtin temperate sensor I believe the guidance is to avoid describing kernel behavior in DT property so I think it should say: - ts-attached: boolean indicating that an actual touchscreen is attached to the controller. Thanks. -- Dmitry