From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 0/2] input: mt: Add helper function to send end events Date: Tue, 31 Dec 2013 10:50:36 -0800 Message-ID: <20131231185035.GD6897@core.coreip.homeip.net> References: <1388455601-17033-1-git-send-email-eu@felipetonello.com> <52C28DC7.9020003@euromail.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f48.google.com ([209.85.160.48]:39386 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756166Ab3LaSuj (ORCPT ); Tue, 31 Dec 2013 13:50:39 -0500 Content-Disposition: inline In-Reply-To: <52C28DC7.9020003@euromail.se> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Henrik Rydberg Cc: "Felipe F. Tonello" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Hi Henrik, On Tue, Dec 31, 2013 at 10:26:31AM +0100, Henrik Rydberg wrote: > Hi Felipe, > > > Adds a helper function to send end touch events for active tracking ids. > > And also implements it in egalax driver. > > What problematic scenario is this supposed to solve? > > The 'release on suspend' is only an approximation to the 'close > laptop' scenario, it is certainly not correct in the coffee table > case, Why would it not be correct for coffee table? Do we expect the touches to remain valid while the device is asleep? > for instance. Instead of > hardcoding this in the kernel, userland can easily detect long intervals > directly using the event time. But with slots it is not only problem with old events being sent out later, it is that we have mix of old (pre-sleep) and new state. > > Unless there is already a reasonable mechanism in your user > application which deals with cases like this but fails to account for > your particular problem scenario, the patch will not be applied. > We do that for keys (release them when we transition to system sleep) and I think it might be worthwhile to do the same for touch data. Thanks. -- Dmitry