From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ims-pcu: Add commands supported by the new version of the FW
Date: Wed, 8 Jan 2014 22:43:38 -0800 [thread overview]
Message-ID: <20140109064338.GA29893@core.coreip.homeip.net> (raw)
In-Reply-To: <CAHQ1cqFaXCXw8UTwRVw72mmf7e_t3QjWNMshccEchsmR-2DVbw@mail.gmail.com>
On Wed, Jan 08, 2014 at 09:57:20PM -0800, Andrey Smirnov wrote:
> On Mon, Jan 6, 2014 at 11:14 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > Andrey, were you able to test the patch?
>
> Hi Dmitry,
>
> I tested the patch and with exception of a trivial to fix typo/bug it
> worked fine.
>
> I see that you moved the OFN attributes to a dedicated directory,
> which I personally like better, but I am not sure if IMS would not
> want to push back on it since they might have started to use the API
> already. I'll send a new version to Chris so that he can do some
> additional testing and see if they can incorporate that naming change.
> I'll e-mail you v3 of the patch as soon as that matter becomes more
> clear.
Andrey,
I am pretty sure that the new sysfs layout with OFN group split makes
most sense. Luckily this is brand new functionality so IMS should be
able to adjust their userspace to accommodate it.
Thanks.
--
Dmitry
prev parent reply other threads:[~2014-01-09 6:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 0:47 [PATCH v2] ims-pcu: Add commands supported by the new version of the FW Andrey Smirnov
2014-01-04 1:39 ` Dmitry Torokhov
2014-01-04 4:24 ` Andrey Smirnov
2014-01-04 4:44 ` Dmitry Torokhov
2014-01-04 5:03 ` Andrey Smirnov
2014-01-04 5:41 ` Dmitry Torokhov
2014-01-07 7:14 ` Dmitry Torokhov
2014-01-07 19:14 ` Andrey Smirnov
2014-01-09 5:57 ` Andrey Smirnov
2014-01-09 6:43 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109064338.GA29893@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=andrew.smirnov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).