From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2] input: synaptics-rmi4 - use snprintf instead of sprintf in rmi_i2c.c Date: Thu, 9 Jan 2014 00:28:58 -0800 Message-ID: <20140109082858.GE27160@core.coreip.homeip.net> References: <1389230319-4737-1-git-send-email-cheiny@synaptics.com> <20140109080454.GA27160@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pd0-f182.google.com ([209.85.192.182]:35779 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbaAII3C (ORCPT ); Thu, 9 Jan 2014 03:29:02 -0500 Received: by mail-pd0-f182.google.com with SMTP id v10so2903389pde.27 for ; Thu, 09 Jan 2014 00:29:01 -0800 (PST) Content-Disposition: inline In-Reply-To: <20140109080454.GA27160@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Christopher Heiny Cc: Linux Input , Andrew Duggan , Vincent Huang , Vivian Ly , Daniel Rosenberg , Jean Delvare , Joerie de Gram , Linus Walleij , Benjamin Tissoires On Thu, Jan 09, 2014 at 12:04:54AM -0800, Dmitry Torokhov wrote: > On Wed, Jan 08, 2014 at 05:18:39PM -0800, Christopher Heiny wrote: > > This is a trivial change to replace the sprintf loop with snprintf using > > up-to-date format capability. > > Hmm, how about we do this instead: And another small one... Input: synaptics-rmi4 - transport name should be a const pointer From: Dmitry Torokhov Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_bus.h | 2 +- drivers/input/rmi4/rmi_i2c.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/input/rmi4/rmi_bus.h b/drivers/input/rmi4/rmi_bus.h index 65dd934..3e8b57a 100644 --- a/drivers/input/rmi4/rmi_bus.h +++ b/drivers/input/rmi4/rmi_bus.h @@ -148,7 +148,7 @@ struct rmi_driver { * @att_count Number of times ATTN assertions have been handled. */ struct rmi_transport_info { - char *proto; + const char *proto; long tx_count; long tx_bytes; long tx_errs; diff --git a/drivers/input/rmi4/rmi_i2c.c b/drivers/input/rmi4/rmi_i2c.c index ea01823..ebe74ec 100644 --- a/drivers/input/rmi4/rmi_i2c.c +++ b/drivers/input/rmi4/rmi_i2c.c @@ -38,8 +38,6 @@ struct rmi_i2c_data { #define RMI_PAGE_SELECT_REGISTER 0xff #define RMI_I2C_PAGE(addr) (((addr) >> 8) & 0xff) -static char *xport_proto_name = "i2c"; - /* * rmi_set_page - Set RMI page * @xport: The pointer to the rmi_transport_dev struct @@ -217,7 +215,7 @@ static int rmi_i2c_probe(struct i2c_client *client, xport->write_block = rmi_i2c_write_block; xport->read_block = rmi_i2c_read_block; - xport->info.proto = xport_proto_name; + xport->info.proto = "i2c"; mutex_init(&data->page_mutex); -- Dmitry