From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [RFC][PATCH] module: allow multiple calls to MODULE_DEVICE_TABLE() per module Date: Mon, 27 Jan 2014 11:54:22 -0800 Message-ID: <20140127195422.GB21018@kroah.com> References: <1390849795-2155-1-git-send-email-teg@jklm.no> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:36073 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753580AbaA0TxR (ORCPT ); Mon, 27 Jan 2014 14:53:17 -0500 Content-Disposition: inline In-Reply-To: <1390849795-2155-1-git-send-email-teg@jklm.no> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Tom Gundersen Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, kay@vrfy.org, Dmitry Torokhov , Rusty Russell On Mon, Jan 27, 2014 at 08:09:55PM +0100, Tom Gundersen wrote: > Commit 78551277e4df5: "Input: i8042 - add PNP modaliases" had a bug, where the > second call to MODULE_DEVICE_TABLE() overrode the first resulting in not all > the modaliases being exposed. > > This fixes the problem by including the name of the device_id table in the > __mod_*_device_table alias, allowing us to export several device_id tables > per module. > > Suggested-by: Kay Sievers > Cc: Dmitry Torokhov > Cc: Greg Kroah-Hartman > Cc: Rusty Russell > --- > include/linux/module.h | 2 +- > scripts/mod/file2alias.c | 14 +++++++++----- > 2 files changed, 10 insertions(+), 6 deletions(-) Ah, very nice, I've wanted this for a while now, it would make a number of different drivers much smaller and simpler to add new device ids to (no multiple lists of ids, one for the module loader and one for the sub-driver that is in the single file.) If this doesn't break any userspace tools, I have no objection to it at all: Acked-by: Greg Kroah-Hartman