From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH RFC] Input: Add Microchip AR1021 i2c touchscreen Date: Fri, 31 Jan 2014 09:15:21 -0800 Message-ID: <20140131171521.GA20872@core.coreip.homeip.net> References: <1391074185-26973-1-git-send-email-christian.gmeiner@gmail.com> <20140131010131.GA29566@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f54.google.com ([209.85.160.54]:43819 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932331AbaAaRPZ (ORCPT ); Fri, 31 Jan 2014 12:15:25 -0500 Received: by mail-pb0-f54.google.com with SMTP id uo5so4695637pbc.27 for ; Fri, 31 Jan 2014 09:15:25 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Christian Gmeiner Cc: linux-input@vger.kernel.org Hi Chrisitian, On Fri, Jan 31, 2014 at 12:40:19PM +0100, Christian Gmeiner wrote: > >> --- /dev/null > >> +++ b/drivers/input/touchscreen/ar1021_i2c.c > >> @@ -0,0 +1,201 @@ > >> +/* > >> + * Microchip AR1021 driver for I2C > >> + * > >> + * Author: Christian Gmeiner > >> + * > >> + * License: GPL as published by the FSF. By the way, you probably do not want GPL v1 to apply... Maybe say GPL v2 or GPL v2 and later (depending on your preference and the license of the code you used as a base)? > >> + > >> +static int ar1021_i2c_resume(struct device *dev) > >> +{ > >> + struct i2c_client *client = to_i2c_client(dev); > >> + > >> + enable_irq(client->irq); > > > > You do not want to enable IRQ if there are no users (nobody opened > > device). > > > > Okay.. but then I also do not need the disable_irq(..) call in > ar1021_i2c_suspend > and can totally remove the PM stuff - or? No, I think you still need the PM methods, you just need to check if device is opened (take dev->mutex, check dev->users) and decide if you need to enable/disable IRQ or not. -- Dmitry