From: "Anthony Olech <anthony.olech.opensource@diasemi.com>" <Anthony.Olech.OpenSource@diasemi.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
David Dajun Chen <david.chen@diasemi.com>
Subject: [PATCH V1] da9052: ONKEY: use correct register bit for key status
Date: Thu, 6 Feb 2014 15:19:49 +0000 [thread overview]
Message-ID: <201402111610.s1BGAXJo056493@swsrvapps-02.lan> (raw)
The wrong register bit of the DA9052/3 PMIC registers was
used to determine the status on the ONKEY.
Signed-off-by: Anthony Olech <anthony.olech.opensource@diasemi.com>
Signed-off-by: David Dajun Chen <david.chen@diasemi.com>
---
This patch is relative to linux-next repository tag next-20140206
The bug that this patch fixes affects only the DA9052 ONKEY driver.
The problem was detected whilst running a scripted set of functional
regression tests whilst investigating a different problem.
This patch has been test compiled on an amd64 server for both x86
and arm targets.
This patch has been spot verified using an SMDK6410 platform
fly-wired to a Dialog da9053 EVB.
drivers/input/misc/da9052_onkey.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/input/misc/da9052_onkey.c b/drivers/input/misc/da9052_onkey.c
index 1f695f2..7e78334 100644
--- a/drivers/input/misc/da9052_onkey.c
+++ b/drivers/input/misc/da9052_onkey.c
@@ -27,19 +27,23 @@ struct da9052_onkey {
static void da9052_onkey_query(struct da9052_onkey *onkey)
{
- int key_stat;
+ int ret, key_stat;
- key_stat = da9052_reg_read(onkey->da9052, DA9052_EVENT_B_REG);
- if (key_stat < 0) {
+ ret = da9052_reg_read(onkey->da9052, DA9052_STATUS_A_REG);
+ if (ret < 0) {
dev_err(onkey->da9052->dev,
- "Failed to read onkey event %d\n", key_stat);
+ "Failed to read onkey event err=%d\n", ret);
+ key_stat = false;
} else {
/*
* Since interrupt for deassertion of ONKEY pin is not
* generated, onkey event state determines the onkey
* button state.
*/
- key_stat &= DA9052_EVENTB_ENONKEY;
+ if (ret & DA9052_STATUSA_NONKEY)
+ key_stat = false;
+ else
+ key_stat = true;
input_report_key(onkey->input, KEY_POWER, key_stat);
input_sync(onkey->input);
}
--
end-of-patch for da9052: ONKEY: use correct register bit for key status V1
next reply other threads:[~2014-02-11 16:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 15:19 Anthony Olech <anthony.olech.opensource@diasemi.com> [this message]
2014-02-11 16:28 ` [PATCH V1] da9052: ONKEY: use correct register bit for key status Dmitry Torokhov
2014-02-11 16:57 ` Opensource [Anthony Olech]
2014-02-11 17:06 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402111610.s1BGAXJo056493@swsrvapps-02.lan \
--to=anthony.olech.opensource@diasemi.com \
--cc=david.chen@diasemi.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).