From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Barry Song <21cnbao@gmail.com>
Cc: linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, workgroup.linux@csr.com,
Xianglong Du <Xianglong.Du@csr.com>,
Rongjun Ying <Rongjun.Ying@csr.com>,
Barry Song <Baohua.Song@csr.com>
Subject: Re: [PATCH] input: sirfsoc-onkey - report onkey untouch event by detecting pin status
Date: Wed, 12 Feb 2014 15:11:31 -0800 [thread overview]
Message-ID: <20140212231131.GA29769@core.coreip.homeip.net> (raw)
In-Reply-To: <1392026859-4977-1-git-send-email-21cnbao@gmail.com>
Hi Barry,
On Mon, Feb 10, 2014 at 06:07:39PM +0800, Barry Song wrote:
>
> static int sirfsoc_pwrc_remove(struct platform_device *pdev)
> {
> + struct sirfsoc_pwrc_drvdata *pwrcdrv = dev_get_drvdata(&pdev->dev);
> +
> device_init_wakeup(&pdev->dev, 0);
>
> + cancel_delayed_work_sync(&pwrcdrv->work);
> +
This is racy: interrupt is freed later and can schedule work again.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-02-12 23:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 10:07 [PATCH] input: sirfsoc-onkey - report onkey untouch event by detecting pin status Barry Song
2014-02-12 23:11 ` Dmitry Torokhov [this message]
2014-02-13 2:32 ` Barry Song
2014-02-13 3:41 ` Dmitry Torokhov
2014-02-13 6:48 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212231131.GA29769@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=21cnbao@gmail.com \
--cc=Baohua.Song@csr.com \
--cc=Rongjun.Ying@csr.com \
--cc=Xianglong.Du@csr.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).