From: Josh Cartwright <joshc@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v4 4/9] Input: pmic8xxx-keypad - Migrate to DT
Date: Thu, 27 Feb 2014 21:41:38 -0600 [thread overview]
Message-ID: <20140228034138.GD7308@joshc.qualcomm.com> (raw)
In-Reply-To: <1393552520-9068-5-git-send-email-sboyd@codeaurora.org>
Looks good, with the exception of one thing...
On Thu, Feb 27, 2014 at 05:55:15PM -0800, Stephen Boyd wrote:
> The driver is only supported on DT enabled platforms. Convert the
> driver to DT so that it can probe properly.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/input/keyboard/pmic8xxx-keypad.c | 150 ++++++++++++++++++-------------
> @@ -471,50 +514,27 @@ static void pmic8xxx_kp_close(struct input_dev *dev)
> */
> static int pmic8xxx_kp_probe(struct platform_device *pdev)
> {
[..]
> - keymap_data = pdata->keymap_data;
> - if (!keymap_data) {
> - dev_err(&pdev->dev, "no keymap data supplied\n");
> - return -EINVAL;
> - }
> + repeat = !of_property_read_bool(pdev->dev.of_node,
> + "linux,input-no-autorepeat");
> + wakeup = !of_property_read_bool(pdev->dev.of_node,
> + "linux,keypad-wakeup");
I don't think you mean to invert this.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-28 3:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 1:55 [PATCH v4 0/9] Use regmap+devm+DT in pm8xxx input drivers Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 1/9] Input: pmic8xxx-keypad - Fix build by removing gpio configuration Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 2/9] Input: pmic8xxx-keypad - Migrate to devm_* APIs Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 3/9] Input: pmic8xxx-keypad - Migrate to regmap APIs Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 4/9] Input: pmic8xxx-keypad - Migrate to DT Stephen Boyd
2014-02-28 3:41 ` Josh Cartwright [this message]
2014-02-28 18:29 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 5/9] Input: pmic8xxx-pwrkey " Stephen Boyd
2014-02-28 3:45 ` Josh Cartwright
2014-02-28 18:32 ` Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 6/9] Input: pm8xxx-vibrator - Add DT match table Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 7/9] devicetree: bindings: Document PM8921/8058 keypads Stephen Boyd
2014-02-28 13:55 ` Josh Cartwright
2014-02-28 18:37 ` Stephen Boyd
2014-02-28 19:11 ` Josh Cartwright
2014-02-28 1:55 ` [PATCH v4 8/9] devicetree: bindings: Document PM8921/8058 power keys Stephen Boyd
2014-02-28 1:55 ` [PATCH v4 9/9] devicetree: bindings: Document PM8921/8058 vibrators Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228034138.GD7308@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).