From: Steven Rostedt <rostedt@goodmis.org>
To: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
Cc: "'alsa-devel@alsa-project.org'" <alsa-devel@alsa-project.org>,
"'linux-usb@vger.kernel.org'" <linux-usb@vger.kernel.org>,
"'tiwai@suse.de'" <tiwai@suse.de>,
"'fweisbec@gmail.com'" <fweisbec@gmail.com>,
"'dmitry.torokhov@gmail.com'" <dmitry.torokhov@gmail.com>,
"'mingo@redhat.com'" <mingo@redhat.com>,
"'linux-input@vger.kernel.org'" <linux-input@vger.kernel.org>,
"'rydberg@euromail.se'" <rydberg@euromail.se>,
"'lrg@ti.com'" <lrg@ti.com>,
"'pablo@netfilter.org'" <pablo@netfilter.org>,
"'coreteam@netfilter.org'" <coreteam@netfilter.org>,
"'linux-arm-msm@vger.kernel.org'" <linux-arm-msm@vger.kernel.org>,
"'netfilter@vger.kernel.org'" <netfilter@vger.kernel.org>,
"'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>,
"'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
"'broonie@opensource.wolfsonmicro.com'"
<broonie@opensource.wolfsonmicro.>
Subject: Re: change kmalloc into vmalloc for large memory allocations
Date: Fri, 28 Feb 2014 09:11:38 -0500 [thread overview]
Message-ID: <20140228091138.39b90f52@gandalf.local.home> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D102844605F38C@CNBJMBX05.corpusers.net>
On Fri, 28 Feb 2014 16:15:23 +0800
"Wang, Yalin" <Yalin.Wang@sonymobile.com> wrote:
> Kfree(ptr)
> {
> If (is_vmalloc_addr(ptr))
> Vfree(ptr);
> Else
> Kfree(ptr);
> }
>
>
> But we need add some flags to ensure always use kmalloc for
> Some special use (dma etc..)
>
> How do you think of it ?
But vmalloc also takes up tlb entries. The more vmalloc space you have,
the more tlb entries that will need to be used, which will have a
performance affect on the entire system.
I would be against making kmalloc() secretly doing a vmalloc. If it is
better for a driver to use a vmalloc on large items, than change the
driver. Don't change a core function.
-- Steve
next prev parent reply other threads:[~2014-02-28 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 8:15 change kmalloc into vmalloc for large memory allocations Wang, Yalin
2014-02-28 8:54 ` Huang Shijie
2014-02-28 9:20 ` Wang, Yalin
2014-02-28 16:33 ` 'gregkh@linuxfoundation.org'
2014-03-03 2:51 ` Wang, Yalin
2014-03-03 3:08 ` 'gregkh@linuxfoundation.org'
2014-03-03 8:00 ` Wang, Yalin
2014-03-03 14:10 ` 'gregkh@linuxfoundation.org'
2014-03-04 7:30 ` [PATCH] netfilter:Change nf_conntrack modules to use vmalloc Wang, Yalin
2014-02-28 14:11 ` Steven Rostedt [this message]
2014-02-28 14:19 ` change kmalloc into vmalloc for large memory allocations Takashi Iwai
2014-03-03 1:55 ` Wang, Yalin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228091138.39b90f52@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Yalin.Wang@sonymobile.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro. \
--cc=coreteam@netfilter.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lrg@ti.com \
--cc=mingo@redhat.com \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rydberg@euromail.se \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox