From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Caione Subject: Re: Re: [PATCH 6/7] regulator: AXP20x: Add support for regulators subsystem Date: Sun, 9 Mar 2014 09:56:18 +0100 Message-ID: <20140309085618.GA4683@localhost.fastwebnet.it> References: <1393692352-10839-1-git-send-email-carlo@caione.org> <1393692352-10839-7-git-send-email-carlo@caione.org> <20140307182213.GC607@lukather> <20140309075148.GJ28112@sirena.org.uk> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140309075148.GJ28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline To: Mark Brown Cc: Maxime Ripard , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-input@vger.kernel.org On Sun, Mar 09, 2014 at 07:51:48AM +0000, Mark Brown wrote: > On Sat, Mar 08, 2014 at 12:43:04PM +0100, Carlo Caione wrote: > > On Fri, Mar 7, 2014 at 7:22 PM, Maxime Ripard > > > On Sat, Mar 01, 2014 at 05:45:51PM +0100, Carlo Caione wrote: > > > >> + return platform_driver_register(&axp20x_regulator_driver); > > > > I thought the AXP was only connected through I2C? How is that a > > > platform device then? > > > Not really. It is plain wrong. > > I'll fix it in v2. > > Are you sure this is wrong? For MFDs the core MFD is a driver of > whatever bus type is in use but the function drivers are platform > devices which talk to the hardware via the core device. ok, I spoke too soon. Sorry for the noise. -- Carlo Caione