* [PATCH] Input: fix dependencies of OLPC AP-SP driver
@ 2014-03-11 18:42 Jean Delvare
2014-03-12 6:11 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2014-03-11 18:42 UTC (permalink / raw)
To: linux-input; +Cc: Dmitry Torokhov
I don't think the OLPC AP-SP driver is generally useful without OLPC
support. So make it depend on OLPC, unless build testing is enabled.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/serio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.14-rc6.orig/drivers/input/serio/Kconfig 2014-02-09 16:53:02.931633818 +0100
+++ linux-3.14-rc6/drivers/input/serio/Kconfig 2014-03-11 18:52:42.280541110 +0100
@@ -263,7 +263,7 @@ config SERIO_APBPS2
config SERIO_OLPC_APSP
tristate "OLPC AP-SP input support"
- depends on OF
+ depends on OLPC || (OF && COMPILE_TEST)
help
Say Y here if you want support for the keyboard and touchpad included
in the OLPC XO-1.75 and XO-4 laptops.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: fix dependencies of OLPC AP-SP driver
2014-03-11 18:42 [PATCH] Input: fix dependencies of OLPC AP-SP driver Jean Delvare
@ 2014-03-12 6:11 ` Dmitry Torokhov
2014-03-12 13:04 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2014-03-12 6:11 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-input
Hi Jean,
On Tue, Mar 11, 2014 at 07:42:53PM +0100, Jean Delvare wrote:
> I don't think the OLPC AP-SP driver is generally useful without OLPC
> support. So make it depend on OLPC, unless build testing is enabled.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/serio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-3.14-rc6.orig/drivers/input/serio/Kconfig 2014-02-09 16:53:02.931633818 +0100
> +++ linux-3.14-rc6/drivers/input/serio/Kconfig 2014-03-11 18:52:42.280541110 +0100
> @@ -263,7 +263,7 @@ config SERIO_APBPS2
>
> config SERIO_OLPC_APSP
> tristate "OLPC AP-SP input support"
> - depends on OF
> + depends on OLPC || (OF && COMPILE_TEST)
Actually for compile coverage we do not actually need OF, I'll make it
depends on OLPC || COMPILE_TEST
instead.
> help
> Say Y here if you want support for the keyboard and touchpad included
> in the OLPC XO-1.75 and XO-4 laptops.
>
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: fix dependencies of OLPC AP-SP driver
2014-03-12 6:11 ` Dmitry Torokhov
@ 2014-03-12 13:04 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2014-03-12 13:04 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
Hi Dmitry,
On Tue, 11 Mar 2014 23:11:34 -0700, Dmitry Torokhov wrote:
> On Tue, Mar 11, 2014 at 07:42:53PM +0100, Jean Delvare wrote:
> > I don't think the OLPC AP-SP driver is generally useful without OLPC
> > support. So make it depend on OLPC, unless build testing is enabled.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> > drivers/input/serio/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-3.14-rc6.orig/drivers/input/serio/Kconfig 2014-02-09 16:53:02.931633818 +0100
> > +++ linux-3.14-rc6/drivers/input/serio/Kconfig 2014-03-11 18:52:42.280541110 +0100
> > @@ -263,7 +263,7 @@ config SERIO_APBPS2
> >
> > config SERIO_OLPC_APSP
> > tristate "OLPC AP-SP input support"
> > - depends on OF
> > + depends on OLPC || (OF && COMPILE_TEST)
>
> Actually for compile coverage we do not actually need OF, I'll make it
>
> depends on OLPC || COMPILE_TEST
>
> instead.
Ah, you're right. Thanks for spotting it, your solution is easier and
cleaner :)
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-12 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-11 18:42 [PATCH] Input: fix dependencies of OLPC AP-SP driver Jean Delvare
2014-03-12 6:11 ` Dmitry Torokhov
2014-03-12 13:04 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).