From: Jean Delvare <jdelvare@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: fix dependencies of OLPC AP-SP driver
Date: Wed, 12 Mar 2014 14:04:50 +0100 [thread overview]
Message-ID: <20140312140450.657f1639@endymion.delvare> (raw)
In-Reply-To: <20140312061134.GA2263@core.coreip.homeip.net>
Hi Dmitry,
On Tue, 11 Mar 2014 23:11:34 -0700, Dmitry Torokhov wrote:
> On Tue, Mar 11, 2014 at 07:42:53PM +0100, Jean Delvare wrote:
> > I don't think the OLPC AP-SP driver is generally useful without OLPC
> > support. So make it depend on OLPC, unless build testing is enabled.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> > drivers/input/serio/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-3.14-rc6.orig/drivers/input/serio/Kconfig 2014-02-09 16:53:02.931633818 +0100
> > +++ linux-3.14-rc6/drivers/input/serio/Kconfig 2014-03-11 18:52:42.280541110 +0100
> > @@ -263,7 +263,7 @@ config SERIO_APBPS2
> >
> > config SERIO_OLPC_APSP
> > tristate "OLPC AP-SP input support"
> > - depends on OF
> > + depends on OLPC || (OF && COMPILE_TEST)
>
> Actually for compile coverage we do not actually need OF, I'll make it
>
> depends on OLPC || COMPILE_TEST
>
> instead.
Ah, you're right. Thanks for spotting it, your solution is easier and
cleaner :)
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2014-03-12 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 18:42 [PATCH] Input: fix dependencies of OLPC AP-SP driver Jean Delvare
2014-03-12 6:11 ` Dmitry Torokhov
2014-03-12 13:04 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312140450.657f1639@endymion.delvare \
--to=jdelvare@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).