From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Caione Subject: Re: Re: [PATCH v2 6/8] ARM: sunxi: dt: Add x-powers-axp209.dtsi file Date: Sat, 22 Mar 2014 15:31:57 +0100 Message-ID: <20140322143157.GB20668@localhost.fastwebnet.it> References: <1394898225-28452-1-git-send-email-carlo@caione.org> <1394898225-28452-7-git-send-email-carlo@caione.org> <20140318090450.GV27873@lukather> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20140318090450.GV27873@lukather> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline To: Maxime Ripard Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-input@vger.kernel.org On Tue, Mar 18, 2014 at 10:04:50AM +0100, Maxime Ripard wrote: > On Sat, Mar 15, 2014 at 04:43:43PM +0100, Carlo Caione wrote: > > This dtsi describes the axp209 PMIC, and is to be included from inside > > the i2c controller node to which the axp209 is connected. > > > > Signed-off-by: Hans de Goede > > Signed-off-by: Carlo Caione > > --- > > arch/arm/boot/dts/x-powers-axp209.dtsi | 60 ++++++++++++++++++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 arch/arm/boot/dts/x-powers-axp209.dtsi > > > > diff --git a/arch/arm/boot/dts/x-powers-axp209.dtsi b/arch/arm/boot/dts/x-powers-axp209.dtsi > > new file mode 100644 > > index 0000000..d272e67 > > --- /dev/null > > +++ b/arch/arm/boot/dts/x-powers-axp209.dtsi > > @@ -0,0 +1,60 @@ > > +/* > > + * x-powers,axp209 common code to be include from inside the axp209 node > > + * > > + * Copyright 2014 - Carlo Caione > > + * > > + * The code contained herein is licensed under the GNU General Public > > + * License. You may obtain a copy of the GNU General Public License > > + * Version 2 or later at the following locations: > > + * > > + * http://www.opensource.org/licenses/gpl-license.html > > + * http://www.gnu.org/copyleft/gpl.html > > + */ > > + > > I didn't even know such a thing was possible :) > Nice hack. Kudos to Hans ;) > > > + compatible = "x-powers,axp209"; > > + interrupt-controller; > > + #interrupt-cells = <1>; > > However, I'd move this out of it, and in the board file, so that we > actually get an idea by looking at the board DTS of what device we are > actually registering at this given address, and what it's capable of. Do you mean the whole dtsi or just those three lines? -- Carlo Caione