* [patch 16/16] input: serio: hp_sdc: Use del_timer_sync() in exit path [not found] <20140323150557.288925975@linutronix.de> @ 2014-03-23 15:09 ` Thomas Gleixner 2014-03-24 0:24 ` Dmitry Torokhov 0 siblings, 1 reply; 2+ messages in thread From: Thomas Gleixner @ 2014-03-23 15:09 UTC (permalink / raw) To: LKML; +Cc: Julia Lawall, Andrew Morton, Dmitry Torokhov, input [-- Attachment #1: input-serio-hp_sdc-use-del_timer_sync.patch --] [-- Type: text/plain, Size: 705 bytes --] Make sure that no callback is running before we teardown the module. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: input <linux-input@vger.kernel.org> --- drivers/input/serio/hp_sdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: tip/drivers/input/serio/hp_sdc.c =================================================================== --- tip.orig/drivers/input/serio/hp_sdc.c +++ tip/drivers/input/serio/hp_sdc.c @@ -984,7 +984,7 @@ static void hp_sdc_exit(void) free_irq(hp_sdc.irq, &hp_sdc); write_unlock_irq(&hp_sdc.lock); - del_timer(&hp_sdc.kicker); + del_timer_sync(&hp_sdc.kicker); tasklet_kill(&hp_sdc.task); ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 16/16] input: serio: hp_sdc: Use del_timer_sync() in exit path 2014-03-23 15:09 ` [patch 16/16] input: serio: hp_sdc: Use del_timer_sync() in exit path Thomas Gleixner @ 2014-03-24 0:24 ` Dmitry Torokhov 0 siblings, 0 replies; 2+ messages in thread From: Dmitry Torokhov @ 2014-03-24 0:24 UTC (permalink / raw) To: Thomas Gleixner; +Cc: LKML, Julia Lawall, Andrew Morton, input On Sun, Mar 23, 2014 at 03:09:33PM -0000, Thomas Gleixner wrote: > Make sure that no callback is running before we teardown the module. > Applied, thank you Thomas. > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: input <linux-input@vger.kernel.org> > --- > drivers/input/serio/hp_sdc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: tip/drivers/input/serio/hp_sdc.c > =================================================================== > --- tip.orig/drivers/input/serio/hp_sdc.c > +++ tip/drivers/input/serio/hp_sdc.c > @@ -984,7 +984,7 @@ static void hp_sdc_exit(void) > free_irq(hp_sdc.irq, &hp_sdc); > write_unlock_irq(&hp_sdc.lock); > > - del_timer(&hp_sdc.kicker); > + del_timer_sync(&hp_sdc.kicker); > > tasklet_kill(&hp_sdc.task); > > > -- Dmitry ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-24 0:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140323150557.288925975@linutronix.de>
2014-03-23 15:09 ` [patch 16/16] input: serio: hp_sdc: Use del_timer_sync() in exit path Thomas Gleixner
2014-03-24 0:24 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).