From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH resend 2/2] input/serio/8042: Add firmware_id support Date: Sun, 13 Apr 2014 01:23:36 -0700 Message-ID: <20140413082336.GD7267@core.coreip.homeip.net> References: <1397033270-29597-1-git-send-email-hdegoede@redhat.com> <1397033270-29597-3-git-send-email-hdegoede@redhat.com> <20140409182434.GA25308@core.coreip.homeip.net> <20140409182926.GB3196@srcf.ucam.org> <20140409200923.GA25808@core.coreip.homeip.net> <53465E19.1060705@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:33941 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbaDMIXj (ORCPT ); Sun, 13 Apr 2014 04:23:39 -0400 Received: by mail-pb0-f46.google.com with SMTP id rq2so7103219pbb.33 for ; Sun, 13 Apr 2014 01:23:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <53465E19.1060705@redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Hans de Goede Cc: Matthew Garrett , Benjamin Tissoires , Peter Hutterer , linux-input@vger.kernel.org On Thu, Apr 10, 2014 at 11:02:17AM +0200, Hans de Goede wrote: > Hi, > > On 04/09/2014 10:09 PM, Dmitry Torokhov wrote: > > On Wed, Apr 09, 2014 at 07:29:26PM +0100, Matthew Garrett wrote: > >> On Wed, Apr 09, 2014 at 11:24:34AM -0700, Dmitry Torokhov wrote: > >> > >>> Do we need all IDs? I'd expect we only interested in HID, not CIDs? > >> > >> I think HID handles the cases we've seen so far, but we could imagine a > >> system vendor providing their own HID, a trackpad vendor's CID and then > >> the generic mouse CID. It seems better to err on the side of including > >> them. > > > > OK, fair enough. Another question - do we want to prefix IDs with "PNP:" > > prefix so that if we add device tree in the future we'll know what kind > > of IDs we are dealing with? > > I'm a bit divided on this, adding a "PNP: " prefix will make it a bit harder > to parse, OTOH once we will have other users like devicetree knowing where > the info comes from will be very useful. To me in the end the latter argument > wins. Let me know if you agree and I'll do a v3 adding the PNP: prefix. Yes please. -- Dmitry