From: Pavel Machek <pavel@ucw.cz>
To: "Zhu, Lejun" <lejun.zhu@linux.intel.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
yu-sheng Chen <verylong2@gmail.com>
Subject: Re: Fwd: Re: [PATCH v2] input: misc: Add driver for Intel Bay Trail GPIO buttons
Date: Wed, 16 Apr 2014 00:20:01 +0200 [thread overview]
Message-ID: <20140415222001.GA2431@amd.pavel.ucw.cz> (raw)
In-Reply-To: <5338D410.9060406@linux.intel.com>
Hi!
>
> Input: misc - Add driver for Intel Bay Trail GPIO buttons
>
> From: Lejun Zhu <lejun.zhu@linux.intel.com>
>
> This patch adds support for the GPIO buttons on some Intel Bay Trail
> tablets originally running Windows 8. The ACPI description of these
> buttons follows "Windows ACPI Design Guide for SoC Platforms".
Hmm. Is it time for x86 to adopt device tree? Because this is 200
lines of C code which should really have been 10 lines of .dts...
> +
> +/*
> + * Some of the buttons like volume up/down are auto repeat, while others
> + * are not. To support both, we register two platform devices, and put
> + * buttons into them based on whether the key should be auto repeat.
> + */
> +#define BUTTON_TYPES 2
> +
> +struct soc_button_data {
> + struct platform_device *children[BUTTON_TYPES];
> +};
Would it be possible to extend device description so that this hack is
not needed?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-04-15 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5338D095.6020200@linux.intel.com>
2014-03-31 2:33 ` Fwd: Re: [PATCH v2] input: misc: Add driver for Intel Bay Trail GPIO buttons Zhu, Lejun
2014-04-15 22:20 ` Pavel Machek [this message]
2014-04-20 19:58 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415222001.GA2431@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=lejun.zhu@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=verylong2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).