linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: w90p910_ts - depend on ARCH_W90X900
@ 2014-04-01 12:20 Jean Delvare
  2014-04-01 13:17 ` Wan ZongShun
  0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2014-04-01 12:20 UTC (permalink / raw)
  To: linux-input, linux-arm-kernel; +Cc: Wan ZongShun, Dmitry Torokhov

The w90p910_ts touchscreen driver is heavily architecture dependent,
so there is no point in letting it be built on other architectures
than it was written for.

All other W90P910/W90X900 drivers already have that dependency, so it
makes things more consistent and configuration easier.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Wan ZongShun <mcuos.com@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-3.14-rc8.orig/drivers/input/touchscreen/Kconfig	2014-02-09 16:53:02.945634113 +0100
+++ linux-3.14-rc8/drivers/input/touchscreen/Kconfig	2014-04-01 14:10:08.936933702 +0200
@@ -867,7 +867,7 @@ config TOUCHSCREEN_TSC2007
 
 config TOUCHSCREEN_W90X900
 	tristate "W90P910 touchscreen driver"
-	depends on HAVE_CLK
+	depends on ARCH_W90X900
 	help
 	  Say Y here if you have a W90P910 based touchscreen.
 


-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Input: w90p910_ts - depend on ARCH_W90X900
  2014-04-01 12:20 [PATCH] Input: w90p910_ts - depend on ARCH_W90X900 Jean Delvare
@ 2014-04-01 13:17 ` Wan ZongShun
  2014-04-20  5:38   ` Dmitry Torokhov
  0 siblings, 1 reply; 3+ messages in thread
From: Wan ZongShun @ 2014-04-01 13:17 UTC (permalink / raw)
  To: Jean Delvare; +Cc: linux-input, linux-arm-kernel, Dmitry Torokhov

---------- Forwarded message ----------
From: Jean Delvare <jdelvare@suse.de>
Date: 2014-04-01 20:20 GMT+08:00
Subject: [PATCH] Input: w90p910_ts - depend on ARCH_W90X900
To: linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org
抄送: Wan ZongShun <mcuos.com@gmail.com>, Dmitry Torokhov
<dmitry.torokhov@gmail.com>


The w90p910_ts touchscreen driver is heavily architecture dependent,
so there is no point in letting it be built on other architectures
than it was written for.

All other W90P910/W90X900 drivers already have that dependency, so it
makes things more consistent and configuration easier.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Wan ZongShun <mcuos.com@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-3.14-rc8.orig/drivers/input/touchscreen/Kconfig
2014-02-09 16:53:02.945634113 +0100
+++ linux-3.14-rc8/drivers/input/touchscreen/Kconfig    2014-04-01
14:10:08.936933702 +0200
@@ -867,7 +867,7 @@ config TOUCHSCREEN_TSC2007

 config TOUCHSCREEN_W90X900
        tristate "W90P910 touchscreen driver"
-       depends on HAVE_CLK
+       depends on ARCH_W90X900
        help
          Say Y here if you have a W90P910 based touchscreen.

Sure, your idea is reasonable.

Acked-by Wan Zongshun <mcuos.com@gmail.com>

--
Jean Delvare
SUSE L3 Support


-- 
Wan ZongShun.
www.mcuos.com
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Input: w90p910_ts - depend on ARCH_W90X900
  2014-04-01 13:17 ` Wan ZongShun
@ 2014-04-20  5:38   ` Dmitry Torokhov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2014-04-20  5:38 UTC (permalink / raw)
  To: Wan ZongShun; +Cc: Jean Delvare, linux-input, linux-arm-kernel

On Tue, Apr 01, 2014 at 09:17:03PM +0800, Wan ZongShun wrote:
> ---------- Forwarded message ----------
> From: Jean Delvare <jdelvare@suse.de>
> Date: 2014-04-01 20:20 GMT+08:00
> Subject: [PATCH] Input: w90p910_ts - depend on ARCH_W90X900
> To: linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org
> 抄送: Wan ZongShun <mcuos.com@gmail.com>, Dmitry Torokhov
> <dmitry.torokhov@gmail.com>
> 
> 
> The w90p910_ts touchscreen driver is heavily architecture dependent,
> so there is no point in letting it be built on other architectures
> than it was written for.
> 
> All other W90P910/W90X900 drivers already have that dependency, so it
> makes things more consistent and configuration easier.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Wan ZongShun <mcuos.com@gmail.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>  drivers/input/touchscreen/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-3.14-rc8.orig/drivers/input/touchscreen/Kconfig
> 2014-02-09 16:53:02.945634113 +0100
> +++ linux-3.14-rc8/drivers/input/touchscreen/Kconfig    2014-04-01
> 14:10:08.936933702 +0200
> @@ -867,7 +867,7 @@ config TOUCHSCREEN_TSC2007
> 
>  config TOUCHSCREEN_W90X900
>         tristate "W90P910 touchscreen driver"
> -       depends on HAVE_CLK
> +       depends on ARCH_W90X900
>         help
>           Say Y here if you have a W90P910 based touchscreen.
> 
> Sure, your idea is reasonable.
> 
> Acked-by Wan Zongshun <mcuos.com@gmail.com>

Applied, thank you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-04-20  5:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-01 12:20 [PATCH] Input: w90p910_ts - depend on ARCH_W90X900 Jean Delvare
2014-04-01 13:17 ` Wan ZongShun
2014-04-20  5:38   ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).