From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Olivier Gay <ogay@logitech.com>,
linux-input@vger.kernel.org,
Nestor Lopez Casado <nlopezcasad@logitech.com>,
Mathieu Meisser <mmeisser@logitech.com>
Subject: Re: [PATCH] HID: add missing hid usages
Date: Tue, 22 Apr 2014 17:04:57 -0700 [thread overview]
Message-ID: <20140423000457.GA22183@core.coreip.homeip.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1404070949020.8157@pobox.suse.cz>
On Mon, Apr 07, 2014 at 09:49:52AM +0200, Jiri Kosina wrote:
>
> [ adding Dmitry to CC ]
>
> On Fri, 4 Apr 2014, Olivier Gay wrote:
>
> >
> > #define KEY_ALS_TOGGLE 0x230 /* Ambient light sensor */
> >
> > +#define KEY_BUTTONCONFIG 0x240 /* AL Button Configuration */
> > +#define KEY_TASKMANAGER 0x241 /* AL Task/Project Manager */
> > +#define KEY_JOURNAL 0x242 /* AL Log/Journal/Timecard */
> > +#define KEY_CONTROLPANEL 0x243 /* AL Control Panel */
> > +#define KEY_APPSELECT 0x244 /* AL Select Task/Application */
> > +#define KEY_SCREENSAVER 0x245 /* AL Screen Saver */
> > +#define KEY_VOICECOMMAND 0x246 /* Listening Voice Command */
> > +
> > +#define KEY_BRIGHTNESS_INC KEY_BRIGHTNESSUP
> > +#define KEY_BRIGHTNESS_DEC KEY_BRIGHTNESSDOWN
> > +#define KEY_BRIGHTNESS 0x250 /* Display Brightness */
What is it supposed to do exactly? Show OSD for brightness?
> > +#define KEY_BRIGHTNESS_TOGGLE 0x251 /* Backlight Toggle */
We already have KEY_DISPLAYTOGGLE, isn't this the same?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-04-23 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 15:02 [PATCH] HID: add missing hid usages Olivier Gay
2014-04-07 7:49 ` Jiri Kosina
2014-04-14 12:22 ` Olivier Gay
2014-04-23 0:04 ` Dmitry Torokhov [this message]
2014-04-23 9:37 ` Olivier Gay
2014-04-24 23:26 ` Dmitry Torokhov
2014-04-25 8:10 ` Olivier Gay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423000457.GA22183@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=mmeisser@logitech.com \
--cc=nlopezcasad@logitech.com \
--cc=ogay@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).