From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sheng-Liang Song <ssl@chromium.org>
Cc: linux-arm-kernel@lists.infradead.org,
Shawn Nematbakhsh <shawnn@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: atkbd - fix keyboard LG Electronics
Date: Tue, 22 Apr 2014 17:42:34 -0700 [thread overview]
Message-ID: <20140423004233.GC22547@core.coreip.homeip.net> (raw)
In-Reply-To: <1398185970-16331-1-git-send-email-ssl@chromium.org>
Hi Sheng-Liang,
On Tue, Apr 22, 2014 at 09:59:30AM -0700, Sheng-Liang Song wrote:
> After issuing ATKBD_CMD_RESET_DIS, LG Keyboard stop working.
> The workaround is to issue ATKBD_CMD_RESET_DEF after ATKBD_CMD_RESET_DIS.
Hmm, if ATKBD_CMD_RESET_DIS causes keyboard not working should we
simply not call it on LG devices?
The idea for using ATKBD_CMD_RESET_DIS was for keyboard to stop
generating scan codes so they do not interfere with detection/resume and
issuing ATKBD_CMD_RESET_DEF right after ATKBD_CMD_RESET_DIS keeps
keyboard in exactly the same state as it was before (i.e. generating
scancodes).
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-04-23 0:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 16:59 [PATCH] Input: atkbd - fix keyboard LG Electronics Sheng-Liang Song
2014-04-23 0:42 ` Dmitry Torokhov [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-23 1:51 Sheng-Liang Song
2014-04-24 5:25 ` Dmitry Torokhov
2014-04-24 14:57 Sheng-Liang Song
2014-04-25 6:35 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423004233.GC22547@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnn@chromium.org \
--cc=ssl@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).