From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
linux-input@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] Input: ads7877: Remove bitrotted comment
Date: Thu, 24 Apr 2014 23:38:41 -0700 [thread overview]
Message-ID: <20140425063841.GD10433@core.coreip.homeip.net> (raw)
In-Reply-To: <20140423101623.GL12304@sirena.org.uk>
On Wed, Apr 23, 2014 at 11:16:23AM +0100, Mark Brown wrote:
> On Tue, Apr 22, 2014 at 05:39:28PM -0700, Dmitry Torokhov wrote:
> > On Tue, Apr 22, 2014 at 10:18:21PM +0100, Mark Brown wrote:
>
> > > Remove the bitrotted comment, though in actual fact the use case mentioned
> > > is a great use for spi_async() since it would cut down on latency handling
> > > the interrupt by saving us a context switch before we start SPI.
>
> > > This was previously implemented, it was removed in commit b534422b2d11
> > > (Input: ad7877 - switch to using threaded IRQ) for code complexity reasons.
> > > It may be better to revert that commit instead.
>
> > Hmm, maybe.. although I think original would cause device 'stuck' if
> > call to spi_async() fails, so probably not a straight revert...
>
> Probably best just to apply this, then - someone can always reimplement
> if they need to.
OK, applied.
Thanks.
--
Dmitry
prev parent reply other threads:[~2014-04-25 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 21:18 [PATCH] Input: ads7877: Remove bitrotted comment Mark Brown
2014-04-23 0:39 ` Dmitry Torokhov
2014-04-23 10:16 ` Mark Brown
2014-04-25 6:38 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425063841.GD10433@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=broonie@kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).