From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: rotary encoder: implement quarter period mode Date: Wed, 7 May 2014 11:59:33 -0700 Message-ID: <20140507185932.GA22973@core.coreip.homeip.net> References: <1387377798-22344-1-git-send-email-s.hauer@pengutronix.de> <20140507144543.GE27177@e106331-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f45.google.com ([209.85.220.45]:59546 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbaEGS7i (ORCPT ); Wed, 7 May 2014 14:59:38 -0400 Content-Disposition: inline In-Reply-To: <20140507144543.GE27177@e106331-lin.cambridge.arm.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Mark Rutland Cc: Sascha Hauer , "linux-input@vger.kernel.org" , Daniel Mack , "devicetree@vger.kernel.org" , Ezequiel =?iso-8859-1?Q?Garc=EDa?= On Wed, May 07, 2014 at 03:45:43PM +0100, Mark Rutland wrote: > Hi, > > On Wed, Dec 18, 2013 at 02:43:18PM +0000, Sascha Hauer wrote: > > Some rotary encoders have a stable state in all output state > > combinations. Add support for this type of encoder. > > > > Signed-off-by: Sascha Hauer > > Cc: Dmitry Torokhov > > Cc: Daniel Mack > > Cc: linux-input@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > --- > > .../devicetree/bindings/input/rotary-encoder.txt | 1 + > > Documentation/input/rotary-encoder.txt | 9 +++++-- > > drivers/input/misc/rotary_encoder.c | 30 ++++++++++++++++++++-- > > include/linux/rotary_encoder.h | 1 + > > 4 files changed, 37 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/input/rotary-encoder.txt b/Documentation/devicetree/bindings/input/rotary-encoder.txt > > index 3315495..cbdb29b 100644 > > --- a/Documentation/devicetree/bindings/input/rotary-encoder.txt > > +++ b/Documentation/devicetree/bindings/input/rotary-encoder.txt > > @@ -15,6 +15,7 @@ Optional properties: > > - rotary-encoder,rollover: Automatic rollove when the rotary value becomes > > greater than the specified steps or smaller than 0. For absolute axis only. > > - rotary-encoder,half-period: Makes the driver work on half-period mode. > > +- rotary-encoder,quarter-period: Makes the driver work on quarter-period mode. > > The new property looks as sane to me as the half-period property, so for > the binding addition: Actually, maybe we should deprecate rotary-encoder,half-period and instead add rotary-encoder,type property? Thanks. -- Dmitry