From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Chao Xie <chao.xie@marvell.com>
Cc: linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, xiechao.mail@gmail.com
Subject: Re: [PATCH] input: pxa27x-keypad: bug fix of getting scan code
Date: Tue, 13 May 2014 23:12:05 -0700 [thread overview]
Message-ID: <20140514061205.GA13621@core.coreip.homeip.net> (raw)
In-Reply-To: <1390797697-29217-1-git-send-email-chao.xie@marvell.com>
On Mon, Jan 27, 2014 at 12:41:37PM +0800, Chao Xie wrote:
> From: Chao Xie <chao.xie@marvell.com>
>
> The rows of pxa27x-keypad used by each boards are not fixed.
> So in the driver, it will get the rows from DT and register
> the keymap as:
> matrix_keypad_build_keymap(keymap_data, NULL,
> pdata->matrix_key_rows,
> pdata->matrix_key_cols,
> keypad->keycodes, input_dev);
>
> But the scan code is gotten as
> MATRIX_SCAN_CODE(row, col, MATRIX_ROW_SHIFT);
> It is not correct. Fix it as
> MATRIX_SCAN_CODE(row, col, keypad->row_shift);
>
> row_shift is calculated from pdata->matrix_key_rows.
>
> Signed-off-by: Chao Xie <chao.xie@marvell.com>
Applied with minor edits, thank you.
--
Dmitry
prev parent reply other threads:[~2014-05-14 6:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 4:41 [PATCH] input: pxa27x-keypad: bug fix of getting scan code Chao Xie
2014-05-14 6:12 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514061205.GA13621@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=chao.xie@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=xiechao.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).