* [PATCH] input: Request a shared interrupt for AMBA KMI devices.
@ 2014-05-08 12:44 Mark Brown
2014-05-14 6:19 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2014-05-08 12:44 UTC (permalink / raw)
To: Russell King, Dmitry Torokhov
Cc: linux-input, linaro-kernel, Liviu Dudau, Mark Brown
From: Liviu Dudau <Liviu.Dudau@arm.com>
Recent ARM boards have the KMI devices share one interrupt line rather
than having dedicated IRQs. Update the driver to take that into account.
Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/input/serio/ambakmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
index 762b08432de0..8b748d99b934 100644
--- a/drivers/input/serio/ambakmi.c
+++ b/drivers/input/serio/ambakmi.c
@@ -79,7 +79,8 @@ static int amba_kmi_open(struct serio *io)
writeb(divisor, KMICLKDIV);
writeb(KMICR_EN, KMICR);
- ret = request_irq(kmi->irq, amba_kmi_int, 0, "kmi-pl050", kmi);
+ ret = request_irq(kmi->irq, amba_kmi_int, IRQF_SHARED, "kmi-pl050",
+ kmi);
if (ret) {
printk(KERN_ERR "kmi: failed to claim IRQ%d\n", kmi->irq);
writeb(0, KMICR);
--
2.0.0.rc2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] input: Request a shared interrupt for AMBA KMI devices.
2014-05-08 12:44 [PATCH] input: Request a shared interrupt for AMBA KMI devices Mark Brown
@ 2014-05-14 6:19 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2014-05-14 6:19 UTC (permalink / raw)
To: Mark Brown
Cc: Russell King, linux-input, linaro-kernel, Liviu Dudau, Mark Brown
On Thu, May 08, 2014 at 01:44:13PM +0100, Mark Brown wrote:
> From: Liviu Dudau <Liviu.Dudau@arm.com>
>
> Recent ARM boards have the KMI devices share one interrupt line rather
> than having dedicated IRQs. Update the driver to take that into account.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Applied, thank you.
> ---
> drivers/input/serio/ambakmi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
> index 762b08432de0..8b748d99b934 100644
> --- a/drivers/input/serio/ambakmi.c
> +++ b/drivers/input/serio/ambakmi.c
> @@ -79,7 +79,8 @@ static int amba_kmi_open(struct serio *io)
> writeb(divisor, KMICLKDIV);
> writeb(KMICR_EN, KMICR);
>
> - ret = request_irq(kmi->irq, amba_kmi_int, 0, "kmi-pl050", kmi);
> + ret = request_irq(kmi->irq, amba_kmi_int, IRQF_SHARED, "kmi-pl050",
> + kmi);
> if (ret) {
> printk(KERN_ERR "kmi: failed to claim IRQ%d\n", kmi->irq);
> writeb(0, KMICR);
> --
> 2.0.0.rc2
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-14 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 12:44 [PATCH] input: Request a shared interrupt for AMBA KMI devices Mark Brown
2014-05-14 6:19 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).