linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>,
	linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-hotplug@vger.kernel.org, Matthew Garrett <mjg@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: Add keycodes for some missing Fn key combinations
Date: Sat, 17 May 2014 22:38:30 +0200	[thread overview]
Message-ID: <201405172238.30089@pali> (raw)
In-Reply-To: <20140517203054.GA19657@core.coreip.homeip.net>

[-- Attachment #1: Type: Text/Plain, Size: 1482 bytes --]

On Saturday 17 May 2014 22:30:54 Dmitry Torokhov wrote:
> Hi Pali,
> 
> On Sat, May 17, 2014 at 04:43:36PM +0200, Pali Rohár wrote:
> > There are already defined some Fn key combinations, but not
> > all. This patch adds missing combinations for support in
> > dell-wmi driver.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
> > 
> >  include/uapi/linux/input.h |    6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/include/uapi/linux/input.h
> > b/include/uapi/linux/input.h index f484952..3a32799 100644
> > --- a/include/uapi/linux/input.h
> > +++ b/include/uapi/linux/input.h
> > @@ -672,6 +672,12 @@ struct input_keymap_entry {
> > 
> >  #define KEY_FN_F		0x1e2
> >  #define KEY_FN_S		0x1e3
> >  #define KEY_FN_B		0x1e4
> > 
> > +#define KEY_FN_Q		0x1e5
> > +#define KEY_FN_W		0x1e6
> > +#define KEY_FN_R		0x1e7
> > +#define KEY_FN_T		0x1e8
> > +#define KEY_FN_A		0x1e9
> > +#define KEY_FN_G		0x1ea
> 
> What do they actually do?
> 
> Thanks.

All 10 combinations Fn+Q ... Fn+T, Fn+A ... Fn+G are reported by 
WMI and I need to assign some keycodes for them in dell-wmi 
driver. And because More FN_* constants are already defined in 
input.h I added those which are missing.

With this patch series I'm able to use above Fn combinations for 
my own keyboard shortcuts. Before this patch all Fn combinations 
were one same keycode - which was useless.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2014-05-17 20:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201405171639.45722@pali>
2014-05-17 14:43 ` [PATCH 0/2] dell-wmi: Add support for Fn key combinations Pali Rohár
2014-05-17 14:43   ` [PATCH 1/2] Input: Add keycodes for some missing " Pali Rohár
2014-05-17 20:30     ` Dmitry Torokhov
2014-05-17 20:38       ` Pali Rohár [this message]
2014-05-17 21:32         ` Dmitry Torokhov
2014-05-17 14:43   ` [PATCH 2/2] dell-wmi: Add support for " Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201405172238.30089@pali \
    --to=pali.rohar@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).