From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH] HID: rmi: do not handle touchscreens through hid-rmi Date: Tue, 20 May 2014 14:59:16 +0000 Message-ID: <20140520145916.GB9028@mail.corp.redhat.com> References: <1398263514-7281-1-git-send-email-benjamin.tissoires@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jiri Kosina Cc: Andrew Duggan , Christopher Heiny , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On May 20 2014 or thereabouts, Jiri Kosina wrote: > On Wed, 23 Apr 2014, Benjamin Tissoires wrote: > > > Currently, hid-rmi drives every Synaptics product, but the touchscreens > > on the Windows tablets should be handled through hid-multitouch. > > > > Instead of providing a long list of PIDs, rely on the scan_report > > capability to detect which should go to hid-multitouch, and which > > should not go to hid-rmi. > > > > We introduce a generic HID_GROUP_HAVE_SPECIAL_DRIVER which can be reused > > amoung other drivers if they want to have a catch rule but still > > have multitouch devices handled through hid-multitouch. > > > > related bug: > > https://bugzilla.kernel.org/show_bug.cgi?id=74241 > > https://bugzilla.redhat.com/show_bug.cgi?id=1089583 > > > > Signed-off-by: Benjamin Tissoires > > Hi Benjamin, > > sorry for not responding sooner. It's not a big deal. Actually, the Canonical folks reminded me the state of this patch that I completely forgot too :) > > Yes, I have to say I find HID_GROUP_HAVE_SPECIAL_DRIVER very disgusting. > Especially its (non-)relation to hid_have_special_driver[] is very > confusing. > > If you could update this to be RMI-specific (i.e. create a special > HID_GROUP for RMI devices), I'll merge it right away. Ok, I'll add this to the pile of things to do today. Cheers, Benjamin