From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Himangi Saraogi <himangi774@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
julia.lawall@lip6.fr
Subject: Re: [PATCH] touchscreen: Introduce the use of the managed version of kzalloc
Date: Wed, 21 May 2014 08:32:17 -0700 [thread overview]
Message-ID: <20140521153217.GA28195@core.coreip.homeip.net> (raw)
In-Reply-To: <20140521151405.GA8526@himangi-Dell>
Hi Himangi,
On Wed, May 21, 2014 at 08:44:05PM +0530, Himangi Saraogi wrote:
> - input_dev = input_allocate_device();
> + input_dev = devm_input_allocate_device(&pdev->dev);
...
> @@ -365,7 +359,6 @@ static int da9034_touch_remove(struct platform_device *pdev)
> struct da9034_touch *touch = platform_get_drvdata(pdev);
>
> input_unregister_device(touch->input_dev);
When using managed input devices calling input_unregister_device() is
unnecessary. Whole da9034_touch_remove() can be removed. I fixed it up
locally and applied your patch.
Thanks!
> - kfree(touch);
>
> return 0;
> }
> --
> 1.9.1
>
--
Dmitry
prev parent reply other threads:[~2014-05-21 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 15:14 [PATCH] touchscreen: Introduce the use of the managed version of kzalloc Himangi Saraogi
2014-05-21 15:32 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140521153217.GA28195@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=himangi774@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).