From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 20/51] Input: atmel_mxt_ts - Set default irqflags when there is no pdata Date: Sun, 25 May 2014 22:23:20 -0700 Message-ID: <20140526052320.GA12890@core.coreip.homeip.net> References: <1372337366-9286-1-git-send-email-nick.dyer@itdev.co.uk> <1372337366-9286-21-git-send-email-nick.dyer@itdev.co.uk> <20130718171744.GC32381@polaris.bitmath.org> <20130916022533.GA6468@core.coreip.homeip.net> <537E09D6.7050604@itdev.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f44.google.com ([209.85.160.44]:38798 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751151AbaEZFXX (ORCPT ); Mon, 26 May 2014 01:23:23 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Yufeng Shen Cc: Nick Dyer , Benson Leung , Henrik Rydberg , Daniel Kurtz , Joonyoung Shim , Alan Bowens , linux-input , "linux-kernel@vger.kernel.org" , Peter Meerwald , Olof Johansson On Fri, May 23, 2014 at 12:37:46PM -0400, Yufeng Shen wrote: > On Thu, May 22, 2014 at 10:29 AM, Nick Dyer wrote: > > > > Dmitry Torokhov wrote: > > > On Thu, Jul 18, 2013 at 07:17:44PM +0200, rydberg@euromail.se wrote: > > >>> From: Yufeng Shen > > >>> This is the preparation for supporting the code path when there is > > >>> platform data provided and still boot the device into a sane state > > >>> with backup NVRAM config. > > >>> > > >>> Make the irqflags default to be IRQF_TRIGGER_FALLING if no platform data is > > >>> provided. > > > > > > I think if there is no platform data we should use 0 as IRQ falgs and > > > assume that IRQ line is properly configured by the board code or via > > > device tree. > > > > Beson/Yufeng - do you still have a requirement to probe without platform > > data or device tree? I'm just merging in some changes to add device tree > > support, and it would simplify things a bit if I can drop this patch. > > > It has been working for quite a while for boards/devices that don't > provide platform > data. If we drop the default IRQ flags, sure we can add code for each > board to configure > the IRQ separately, but that's just adding extra work. Is there strong > reason why we > should not do the default setting in the driver if it is not already > configured in platform > data ? I am not saying that board code needs to add platform data. I am saying that the board code needs to set up interrupt properly (via irq_set_irq_type() or similar) and then the driver can use 0 as irqflags argument in request_irq() in absence of DT/platform data. Thanks. -- Dmitry