From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH v5] leds: USB: HID: Add support for MSI GT683R led panels Date: Mon, 16 Jun 2014 09:39:57 +0200 Message-ID: <20140616073957.GA20636@localhost> References: <20140612090636.GK10256@localhost> <1402605252-9620-1-git-send-email-janne.kanniainen@gmail.com> <20140613075411.GG10940@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org To: Janne Kanniainen Cc: Johan Hovold , Jiri Kosina , Bryan Wu , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org On Sun, Jun 15, 2014 at 05:59:40PM +0300, Janne Kanniainen wrote: > >> Ok, so you decided to continue setting mode on every LED brightness > >> update. That should be fine, but you never answered my question about > >> whether it is necessary? > > > > I decided to do it that way because official driver did it as well. I > > can check if it is necessary. > > Ok, I checked this one and every time you update LEDs brightness you > will need to update mode also. Ok, great. Then we know. Johan