From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/2] touchscreen: sun4i-ts: A10 (sun4i) has double the temperature precision Date: Mon, 16 Jun 2014 14:30:48 -0700 Message-ID: <20140616213048.GA422@core.coreip.homeip.net> References: <1402943069-19420-1-git-send-email-hdegoede@redhat.com> <1402943069-19420-2-git-send-email-hdegoede@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1402943069-19420-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline To: Hans de Goede Cc: Maxime Ripard , Tong Zhang , linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LM Sensors , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-input@vger.kernel.org Hi Hans, On Mon, Jun 16, 2014 at 08:24:28PM +0200, Hans de Goede wrote: > Testing has revealed that the temperature in the rtp controller of the A10 > (sun4i) SoC has a resolution of 50 milli degrees / step, where as the > A13 (sun5i) and later models have 100 milli degrees / step. > > Add a new sun5i-a13-ts compatible to differentiate the newer models and > set the resolution based on the compatible string. > > This fixes the temperature reported on the A10 being twice as high as expected. Should we maybe add explicit temperature steps property so that we won;t need to patch again if they decided to change resolution again? Thanks. -- Dmitry