From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Przemo Firszt <przemo@firszt.eu>
Cc: linuxwacom-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [Linuxwacom-devel] [PATCH 06/15] Input - wacom: install LED/OLED sysfs files in the HID device instead of USB
Date: Thu, 3 Jul 2014 09:45:47 -0400 [thread overview]
Message-ID: <20140703134547.GA6706@mail.corp.redhat.com> (raw)
In-Reply-To: <20140703092143.Horde.pRrZTs1B-ZEo6Oax4ouKOw1@webmail.firszt.eu>
Hi Przemo,
On Jul 03 2014 or thereabouts, Przemo Firszt wrote:
>
> Quoting Benjamin Tissoires <benjamin.tissoires@redhat.com>:
>
> >Removes one more dependency over USB, but requires some changes in
> >the user space to find the sysfs files correctly.
> >
> >This patch breaks the user space. However, the number of program
> >accessing the LEDs is quite limited and we can easily patch them
> >to handle the new HID behavior.
> [..]
> Hi Bejnamin,
> If you get the green light to break the user space we might as well think
> about getting it in line with led/oled over bluetooth (intuos4 wireless) or
> the other way around.
I think it would be easier to fix the bluetooth (current hid) driver. I
think you already implemented the bluetooth handling in gnome 3.12 and
3.13, but having an uniform way of accessing the LEDs/OLEDs would be
nice.
>
> The biggest user of led/oled functionality is gnome and there are also a few
> small projects that would stop working after that change. I can fix i4oled
> project easily, i4oled-gui is based on gnome handling oleds.
I tried i4oled-gui last week or so, and patching g-s-d was enough. That
was a good idea to rely on gnome internals for your tool :)
>
> Patching those 2 should be enough to fix gnome:
> https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/wacom/gsd-wacom-led-helper.c
> https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/wacom/gsd-wacom-oled-helper.c
Yes, those two are sufficient enough. I had to make the patches
(http://paste.fedoraproject.org/115318/14043949/) so I could test that nothing
was broken. I'll submit those as soon as the fate of this conversion is
decided.
The current libwacom code also need a fix to handle the hid devices
(bluetooth and this series), and I have to send it for a while now :(
Cheers,
Benjamin
next prev parent reply other threads:[~2014-07-03 13:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 21:26 [PATCH 00/15] Input - Wacom: switch from an USB to a HID driver Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 01/15] Input - wacom: include and use linux/hid.h Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 02/15] Input - wacom: switch from an USB driver to a HID driver Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 03/15] Input - wacom: use hid communication instead of plain usb Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 04/15] Input - wacom: use HID core to actually fetch the report descriptor Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 05/15] Input - wacom: compute the HID report size to get the actual packet size Benjamin Tissoires
2014-07-11 1:09 ` Jason Gerecke
2014-07-11 13:20 ` Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 06/15] Input - wacom: install LED/OLED sysfs files in the HID device instead of USB Benjamin Tissoires
2014-07-03 9:21 ` [Linuxwacom-devel] " Przemo Firszt
2014-07-03 13:45 ` Benjamin Tissoires [this message]
2014-06-30 21:26 ` [PATCH 07/15] Input - wacom: register the input devices on top of the HID one Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 08/15] Input - wacom: remove usb dependency for siblings devices Benjamin Tissoires
2014-07-11 0:10 ` Jason Gerecke
2014-07-11 13:15 ` Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 09/15] Input - wacom: register power device at the HID level Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 10/15] Input - wacom: use hid_info instead of plain dev_info Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 11/15] HID: uhid: add and set HID_TYPE_UHID for uhid devices Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 12/15] Input - wacom: use in-kernel HID parser Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 13/15] Input - wacom: use hidinput_calc_abs_res instead of duplicating its code Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 14/15] Input - wacom: remove field pktlen declaration in the list of devices Benjamin Tissoires
2014-06-30 21:26 ` [PATCH 15/15] Input - wacom: keep wacom_ids ordered Benjamin Tissoires
2014-07-02 21:40 ` Benjamin Tissoires
2014-07-02 23:33 ` [PATCH 00/15] Input - Wacom: switch from an USB to a HID driver Jason Gerecke
2014-07-11 1:17 ` Jason Gerecke
2014-07-11 13:30 ` Benjamin Tissoires
2014-07-11 13:47 ` Jiri Kosina
2014-07-10 21:30 ` [Linuxwacom-devel] " Przemo Firszt
2014-07-11 13:28 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140703134547.GA6706@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwacom-devel@lists.sourceforge.net \
--cc=przemo@firszt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).