Re: [PATCH] Input: ambakmi - Use managed interfaces

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Sun, Jul 13, 2014 at 11:00:51PM +0530, Himangi Saraogi wrote:
> @@ -23,6 +23,7 @@
>  #include <linux/clk.h>
>  
>  #include <asm/io.h>
> +#include <linux/io.h>

NAK - please include either linux/io.h _or_ asm/io.h but not both.

> @@ -112,19 +113,10 @@ static int amba_kmi_probe(struct amba_device *dev,
>  {
>  	struct amba_kmi_port *kmi;
>  	struct serio *io;
> -	int ret;
> -
> -	ret = amba_request_regions(dev, NULL);
> -	if (ret)
> -		return ret;

I'm /really/ not happy about that going.

> -
> -	kmi = kzalloc(sizeof(struct amba_kmi_port), GFP_KERNEL);
> -	io = kzalloc(sizeof(struct serio), GFP_KERNEL);
> -	if (!kmi || !io) {
> -		ret = -ENOMEM;
> -		goto out;
> -	}
>  
> +	io = devm_kzalloc(&dev->dev, sizeof(struct serio), GFP_KERNEL);
> +	if (!io)
> +		return -ENOMEM;
>  
>  	io->id.type	= SERIO_8042;
>  	io->write	= amba_kmi_write;
> @@ -135,32 +127,20 @@ static int amba_kmi_probe(struct amba_device *dev,
>  	io->port_data	= kmi;
>  	io->dev.parent	= &dev->dev;
>  
> +	kmi->base	= devm_ioremap_resource(&dev->dev, &dev->res);
> +	if (IS_ERR(kmi->base))
> +		return PTR_ERR(kmi->base);

NAK.  Look carefully through the above changes to work out why.  Please,
if you don't understand what you're doing, or don't even bother with a
build test of the code you've modified, don't even modify it in the
first place.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.