From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <zonque@gmail.com>
Cc: linux-input@vger.kernel.org, broonie@kernel.org,
dh.herrmann@gmail.com, devicetree@vger.kernel.org,
mark.rutland@arm.com
Subject: Re: [PATCH v4] Input: Add driver for Microchip's CAP1106
Date: Mon, 14 Jul 2014 11:46:43 -0700 [thread overview]
Message-ID: <20140714184642.GA38980@core.coreip.homeip.net> (raw)
In-Reply-To: <1405348082-24210-1-git-send-email-zonque@gmail.com>
On Mon, Jul 14, 2014 at 04:28:02PM +0200, Daniel Mack wrote:
> +
> +static int cap1106_i2c_remove(struct i2c_client *i2c_client)
> +{
> + struct cap1106_priv *priv = i2c_get_clientdata(i2c_client);
> +
> + input_unregister_device(priv->idev);
> +
No need to call unregister on managed input devices.
Otherwise if DT guys are happy with bindings I am happy with the patch.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-07-14 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 14:28 [PATCH v4] Input: Add driver for Microchip's CAP1106 Daniel Mack
2014-07-14 18:46 ` Dmitry Torokhov [this message]
2014-07-15 8:53 ` Mark Rutland
2014-07-17 7:55 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714184642.GA38980@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dh.herrmann@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).