From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Andrew Duggan <aduggan@synaptics.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] HID: rmi: only bind the hid-rmi driver to the mouse interface of composite USB devices
Date: Fri, 18 Jul 2014 09:07:05 -0400 [thread overview]
Message-ID: <20140718130705.GB9108@mail.corp.redhat.com> (raw)
In-Reply-To: <1405638885-8014-2-git-send-email-aduggan@synaptics.com>
On Jul 17 2014 or thereabouts, Andrew Duggan wrote:
> On composite HID devices there may be multiple HID devices on separate interfaces, but hid-rmi
> should only bind to the mouse interface. One example is the Dell Venue 11 Pro's keyboard dock
> which contains a composite USB device with a HID touchpad and HID keyboard on separate intefaces.
> Since the USB Vendor ID is Synaptic's, hid-core is currently trying to bind hid-rmi to all\of
> the HID devices. This patch ensures that hid-rmi only binds to the mouse interface.
>
> related bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=80091
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
> ---
As mentioned in a private mail, Andrew told me that for now, each
touchpad using hid-rmi he has seen are using the boot mouse protocol, so
this patch will give us some space and will not break existing current
setups.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/hid-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 8ed66fd..f10e768 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -783,7 +783,9 @@ static int hid_scan_report(struct hid_device *hid)
> * Vendor specific handlings
> */
> if ((hid->vendor == USB_VENDOR_ID_SYNAPTICS) &&
> - (hid->group == HID_GROUP_GENERIC))
> + (hid->group == HID_GROUP_GENERIC) &&
> + /* only bind to the mouse interface of composite USB devices */
> + (hid->bus != BUS_USB || hid->type == HID_TYPE_USBMOUSE))
> /* hid-rmi should take care of them, not hid-generic */
> hid->group = HID_GROUP_RMI;
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-07-18 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 23:14 [PATCH v2] HID: rmi: check that report ids exist in the report_id_hash before accessing their size Andrew Duggan
2014-07-17 23:14 ` [PATCH] HID: rmi: only bind the hid-rmi driver to the mouse interface of composite USB devices Andrew Duggan
2014-07-18 13:07 ` Benjamin Tissoires [this message]
2014-07-29 9:29 ` Jiri Kosina
2014-07-18 13:03 ` [PATCH v2] HID: rmi: check that report ids exist in the report_id_hash before accessing their size Benjamin Tissoires
2014-07-29 9:29 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718130705.GB9108@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=aduggan@synaptics.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).