From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Bivolaru Catalin <bivolaru.catalin@gmail.com>,
kernel-janitors@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com
Subject: Re: [PATCH] staging: input: sunkbd.c: Fix coding style
Date: Sun, 20 Jul 2014 13:19:24 -0700 [thread overview]
Message-ID: <20140720201924.GA18347@core.coreip.homeip.net> (raw)
In-Reply-To: <1405871574.5135.24.camel@joe-AO725>
On Sun, Jul 20, 2014 at 08:52:54AM -0700, Joe Perches wrote:
> On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> > Fix coding style with regard to missing spaces after , and the column limit
> > that was violated after the first change.
>
> Some checkpatch errors should be ignored.
>
> These are some of them.
>
> This change doesn't make it easier to read
> or to find any array entry.
>
> It's currently in groups of 16 (0x10).
>
> This change would make it very difficult
> to find any particular entry.
>
> It might make some sense to change the last
> line to add a trailing " 0, 0" entry as
> the compiler does to make it a bit clearer
> the table has 128 entries.
I'd rather not change a thing in this table - it has been working as is
for many years.
Thanks.
--
Dmitry
prev parent reply other threads:[~2014-07-20 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 12:01 [PATCH] staging: input: sunkbd.c: Fix coding style Bivolaru Catalin
2014-07-20 15:52 ` Joe Perches
2014-07-20 20:19 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140720201924.GA18347@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=bivolaru.catalin@gmail.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).